Logical Model

[wangcj05]

---

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Close #1202

What are the significant changes in functionality due to this change request?

Added LOGICAL MODEL CLASS

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

• 1. Review all computer code.
• 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
• 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
• 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
• 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
• 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
• 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
• 8. If an analytic test is changed/added is the the analytic documentation updated/added?
• 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

[moosebuild]

Job Test Fedora 28 on 51ef98b : invalidated by @wangcj05

python environment issue

[wangcj05]

@mandd @alfoa Please take a look at this PR regarding the LogicalModel Implementation.

[alfoa]

Can you update issue #1225? I know it is tedious but we did not implement an automatic system yet.

[moosebuild]

Job Mingw Test on f4b8567 : invalidated by @wangcj05

fetch issue

[wangcj05]

Can you update issue #1225? I know it is tedious but we did not implement an automatic system yet.

Updated.

[alfoa]

how do we understand which input goes where? If I use codes that require the same input extension (e.g. *.i) how do I know which input goes to which code?

[wangcj05]

Are you fine if I work on this issue in another pull request? Since the changes will also affect EnsembleModel and CodeInterface Entities. It may take longer and further discussion on the solution for this issue.

[alfoa]

Yes. Please, reference a new issue about this.
Thank you.

[wangcj05]

Issue #1240 is created.

[alfoa]

Sorry some "comments" are repeated but are just "place holders:

[wangcj05]

@alfoa I have addressed all your comments except how to handle files for codes.
Are you fine if I work on this issue in another pull request? Since the changes will also affect EnsembleModel and CodeInterface Entities. It may take longer and further discussion on the solution for this issue.

[alfoa]

when the test pass, we can merge this

[wangcj05]

A new issue is created to standardize the way to handle inputs for codes. #1240 @alfoa

[moosebuild]

All jobs on 17a8ae9 : invalidated by @wangcj05

fetch issue on Linux machines

[moosebuild]

Job Mingw Test on 17a8ae9 : invalidated by @wangcj05

fetch issue

[moosebuild]

Job Mingw Test on 0397d8b : invalidated by @joshua-cogliati-inl

restarted civet

[wangcj05]

@alfoa Could you merge this PR? All tests have passed now.

[alfoa]

Checklist passed...

Merging...