-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reject reason for optimizer #1247
Conversation
Job Test CentOS 7 on a68b9ac : invalidated by @joshua-cogliati-inl failed in set python environment. |
@alfoa ready for review |
@JiaZhou-PU ?? |
tests/framework/Optimizers/GradientDescent/gold/ConstrainFunction/opt_export_0.csv
Outdated
Show resolved
Hide resolved
tests/framework/Optimizers/GradientDescent/gold/ConstrainFunction/opt_export_0.csv
Outdated
Show resolved
Hide resolved
@alfoa should be ok this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments addressed... Approved
Checklist satisfied. PR can be merged. @JiaZhou-PU, Please, update issues #1225 (with an explanation of the new feature) |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #1223
What are the significant changes in functionality due to this change request?
Add a reject reason variable to solution export,
noImprovement
means rejected the new optimization point for no improvement from the last point,implicitConstraintsViolation
means rejected by implicit constraints violation, return None if the point is accepted',For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.