Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reject reason for optimizer #1247

Merged
merged 7 commits into from
Jun 23, 2020
Merged

Conversation

JiaZhou-PU
Copy link
Collaborator

@JiaZhou-PU JiaZhou-PU commented Jun 8, 2020


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #1223

What are the significant changes in functionality due to this change request?

Add a reject reason variable to solution export, noImprovement means rejected the new optimization point for no improvement from the last point, implicitConstraintsViolation means rejected by implicit constraints violation, return None if the point is accepted',


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@moosebuild
Copy link

Job Test CentOS 7 on a68b9ac : invalidated by @joshua-cogliati-inl

failed in set python environment.

@JiaZhou-PU JiaZhou-PU requested a review from alfoa June 8, 2020 17:26
@JiaZhou-PU
Copy link
Collaborator Author

@alfoa ready for review

framework/Optimizers/GradientDescent.py Outdated Show resolved Hide resolved
framework/Optimizers/GradientDescent.py Outdated Show resolved Hide resolved
@alfoa
Copy link
Collaborator

alfoa commented Jun 9, 2020

@JiaZhou-PU ??

@alfoa
Copy link
Collaborator

alfoa commented Jun 11, 2020

@JiaZhou-PU

@JiaZhou-PU
Copy link
Collaborator Author

@alfoa should be ok this time.

@alfoa alfoa added the RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 label Jun 23, 2020
Copy link
Collaborator

@alfoa alfoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments addressed... Approved

@alfoa
Copy link
Collaborator

alfoa commented Jun 23, 2020

Checklist satisfied.

PR can be merged.

@JiaZhou-PU, Please, update issues #1225 (with an explanation of the new feature)

@alfoa alfoa merged commit ebb9aa4 into idaholab:devel Jun 23, 2020
@alfoa alfoa deleted the rejectreason branch June 23, 2020 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RAVENv2.1 All tasks and defects that will go in RAVEN v2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] implicit constraint in optimizer. Rejection.
3 participants