Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdsfactory-gen Improvments #235

Closed
8 of 10 tasks
alibillalhammoud opened this issue Sep 5, 2023 · 5 comments
Closed
8 of 10 tasks

Gdsfactory-gen Improvments #235

alibillalhammoud opened this issue Sep 5, 2023 · 5 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@alibillalhammoud
Copy link
Collaborator

alibillalhammoud commented Sep 5, 2023

TODOs for improving gdsfactory-gen code. Feel free to add more items here:

  • ReadME enhancements + add documentation content to the OpenFASOC docs
  • rename pygen
  • organize gds files in tapeout_and_RL directory
  • import klayout drc code from pdk (.drc script)
  • publish package to pypi
  • comments regarding port trees
  • python notebook demo
  • expand the existing docs directory (with the txt files)
  • follow up on requirements.txt: GDSFactory, sky130, and GF180 pypi packages cannot be installed at the same time without broken deps
  • reformat python docustrings into markdown format for better printing in VScode
@alibillalhammoud alibillalhammoud added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 5, 2023
@alibillalhammoud
Copy link
Collaborator Author

@alibillalhammoud
Copy link
Collaborator Author

Added comments from @harshkhandeparkar

@harshkhandeparkar
Copy link
Collaborator

follow up on requirements.txt: GDSFactory, sky130, and GF180 pypi packages cannot be installed at the same time without broken deps

Elaborating on this: gf180 and sky130 have different version requirements of gdsfactory. sky130 requires v7.3.0 and gf180 requires v7.1.4. When either package is installed, it replaces the previously installed version of gdsfactory, leading to broken dependencies. The following error is displayed on installing sky130 after gf180.

Successfully uninstalled gdsfactory-7.1.4
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
gf180 0.0.3 requires gdsfactory[cad]<7.2.0,>=7.1.1, but you have gdsfactory 7.3.0 which is incompatible.
Successfully installed gdsfactory-7.3.0

Even though this error is displayed, the generators still seem to work.

@harshkhandeparkar
Copy link
Collaborator

Opened an issue in the relevant gdsfactory repo: gdsfactory/skywater130#73.

@alibillalhammoud
Copy link
Collaborator Author

I am closing this issue and creating a new one as these tasks have been completed or deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants