Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add label slot #270

Merged
merged 7 commits into from
Aug 5, 2021
Merged

feat: add label slot #270

merged 7 commits into from
Aug 5, 2021

Conversation

schelmo
Copy link
Contributor

@schelmo schelmo commented Aug 5, 2021

Hi,

i added a label slot to replace the input with custom html.
also updated the CustomDropdown example to show the country flag of the current selected option.
vue-next-select in examples directory must be updated therefore after the next release?

@coveralls
Copy link

coveralls commented Aug 5, 2021

Pull Request Test Coverage Report for Build 1101882495

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 15 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 57.187%

Files with Coverage Reduction New Missed Lines %
dist/vue-next-select.es.js 15 57.19%
Totals Coverage Status
Change from base Build 1101727014: 0.5%
Covered Lines: 330
Relevant Lines: 525

💛 - Coveralls

@soc221b
Copy link
Owner

soc221b commented Aug 5, 2021

Thank you for the contribution ❤️ .

No, the version of vue-next-select in examples directory should be automatically bumped by action 😄 .

src/index.vue Outdated Show resolved Hide resolved
soc221b
soc221b previously approved these changes Aug 5, 2021
docs/api-reference.md Show resolved Hide resolved
docs/api-reference.md Outdated Show resolved Hide resolved
@soc221b soc221b dismissed their stale review August 5, 2021 14:05

Still have requests

src/index.vue Outdated Show resolved Hide resolved
Copy link
Owner

@soc221b soc221b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@soc221b soc221b merged commit c9d57c3 into soc221b:develop Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants