Update the template to SDK v0.44 #1307

fadeev · 2021-06-27T05:26:09Z

https://docs.cosmos.network/v0.43/migrations/chain-upgrade-guide-043.html

faddat · 2021-06-27T08:25:23Z

Nice. Didn't know that had been released, I'll look into it.

fadeev · 2021-06-28T05:47:27Z

Only an RC has been released, but it's unlikely that there will be more breaking changes, so it's as good as released as far as Starport is concerned.

faddat · 2021-06-28T08:37:40Z

Alrighty. I will scaffold something, bump it, and make sure that it works correctly and if so I'll put in a PR.

faddat · 2021-06-28T14:40:24Z

github.com/faddat/upgradever/app imports
	github.com/cosmos/cosmos-sdk/x/ibc/applications/transfer: package github.com/cosmos/cosmos-sdk/x/ibc/applications/transfer provided by github.com/cosmos/cosmos-sdk at latest version v0.42.6 but not at required version v0.43.0-rc0
github.com/faddat/upgradever/app imports
	github.com/cosmos/cosmos-sdk/x/ibc/applications/transfer/keeper: package github.com/cosmos/cosmos-sdk/x/ibc/applications/transfer/keeper provided by github.com/cosmos/cosmos-sdk at latest version v0.42.6 but not at required version v0.43.0-rc0
github.com/faddat/upgradever/app imports
	github.com/cosmos/cosmos-sdk/x/ibc/applications/transfer/types: package github.com/cosmos/cosmos-sdk/x/ibc/applications/transfer/types provided by github.com/cosmos/cosmos-sdk at latest version v0.42.6 but not at required version v0.43.0-rc0
github.com/faddat/upgradever/app imports
	github.com/cosmos/cosmos-sdk/x/ibc/core: package github.com/cosmos/cosmos-sdk/x/ibc/core provided by github.com/cosmos/cosmos-sdk at latest version v0.42.6 but not at required version v0.43.0-rc0
github.com/faddat/upgradever/app imports
	github.com/cosmos/cosmos-sdk/x/ibc/core/02-client: package github.com/cosmos/cosmos-sdk/x/ibc/core/02-client provided by github.com/cosmos/cosmos-sdk at latest version v0.42.6 but not at required version v0.43.0-rc0
github.com/faddat/upgradever/app imports
	github.com/cosmos/cosmos-sdk/x/ibc/core/05-port/types: package github.com/cosmos/cosmos-sdk/x/ibc/core/05-port/types provided by github.com/cosmos/cosmos-sdk at latest version v0.42.6 but not at required version v0.43.0-rc0
github.com/faddat/upgradever/app imports
	github.com/cosmos/cosmos-sdk/x/ibc/core/24-host: package github.com/cosmos/cosmos-sdk/x/ibc/core/24-host provided by github.com/cosmos/cosmos-sdk at latest version v0.42.6 but not at required version v0.43.0-rc0
github.com/faddat/upgradever/app imports
	github.com/cosmos/cosmos-sdk/x/ibc/core/keeper: package github.com/cosmos/cosmos-sdk/x/ibc/core/keeper provided by github.com/cosmos/cosmos-sdk at latest version v0.42.6 but not at required version

just adding the sdk-go repo to the various bits since ibc moved and then we should be good to go.

shravanshetty1 · 2021-06-28T19:28:29Z

Looking forward to this!

faddat · 2021-06-29T11:43:07Z

Almost finished. Just working on the antehandler and upgrade module, they've changed a bit too.

Also, feel free to follow along, as I'm starting to think this may require some restructuring. I am checking out simapp in the sdk to try and figure out what that might look like.

Issues are specifically:

It now expects a slightly different kvstore type.
Cleanup is needed on marshaling per: cosmos/cosmos-sdk@d19791b
There are some changes to how IBC things work

It is a larger task than I had thought, but I am enjoying it, thoroughly educational.

faddat · 2021-06-29T12:26:11Z

antehandlers are now like:

	anteHandler, err := ante.NewAnteHandler(
		ante.HandlerOptions{
			AccountKeeper:   app.AccountKeeper,
			BankKeeper:      app.BankKeeper,
			SignModeHandler: encodingConfig.TxConfig.SignModeHandler(),
			FeegrantKeeper:  app.FeeGrantKeeper,
			SigGasConsumer:  ante.DefaultSigVerificationGasConsumer,
		},
	)

faddat · 2021-06-29T13:43:33Z

@fadeev I figure we want the fee grant module and authz, correct?

fadeev · 2021-06-29T14:30:44Z

@faddat since we currently don't have a way to properly import modules, I'd say it's fine to have those in the standard template.

faddat · 2021-06-29T14:34:22Z

They're in.

IBCKeeper is fixed and.... lord knows I'll need to fix another few things.

https://github.com/cosmos/ibc-go/blob/2e95805e2d474b85c837ec433e64947782039047/docs/migrations/ibc-migration-043.md

useful doc!

faddat · 2021-06-29T14:43:39Z

cgo-gcc-prolog:203:11: warning: 'SecTrustedApplicationCreateFromPath' is deprecated: first deprecated in macOS 10.15 - No longer supported [-Wdeprecated-declarations]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecTrustedApplication.h:59:10: note: 'SecTrustedApplicationCreateFromPath' has been explicitly marked deprecated here
# github.com/faddat/supersptest/app
app/app.go:34:2: imported and not used: "github.com/cosmos/cosmos-sdk/x/authz"
app/app.go:427:5: app.Configurator undefined (type *App has no field or method Configurator)
: exit status 2

only small errors remain. Excitement!

faddat · 2021-06-29T15:50:42Z

It'll break wasm a bit I think, this is from root.go:

// initAppConfig helps to override default appConfig template and configs.
// return "", nil if no custom configuration is required for the application.
func initAppConfig() (string, interface{}) {
	// The following code snippet is just for reference.

	// WASMConfig defines configuration for the wasm module.
	type WASMConfig struct {
		// This is the maximum sdk gas (wasm and storage) that we allow for any x/wasm "smart" queries
		QueryGasLimit uint64 `mapstructure:"query_gas_limit"`

		// Address defines the gRPC-web server to listen on
		LruSize uint64 `mapstructure:"lru_size"`
	}

	type CustomAppConfig struct {
		serverconfig.Config

		WASM WASMConfig `mapstructure:"wasm"`
	}

	// Optionally allow the chain developer to overwrite the SDK's default
	// server config.
	srvCfg := serverconfig.DefaultConfig()
	// The SDK's default minimum gas price is set to "" (empty value) inside
	// app.toml. If left empty by validators, the node will halt on startup.
	// However, the chain developer can set a default app.toml value for their
	// validators here.
	//
	// In summary:
	// - if you leave srvCfg.MinGasPrices = "", all validators MUST tweak their
	//   own app.toml config,
	// - if you set srvCfg.MinGasPrices non-empty, validators CAN tweak their
	//   own app.toml to override, or use this default value.
	//
	// In simapp, we set the min gas prices to 0.
	srvCfg.MinGasPrices = "0stake"

	customAppConfig := CustomAppConfig{
		Config: *srvCfg,
		WASM: WASMConfig{
			LruSize:       1,
			QueryGasLimit: 300000,
		},
	}

	customAppTemplate := serverconfig.DefaultConfigTemplate + `
[wasm]
# This is the maximum sdk gas (wasm and storage) that we allow for any x/wasm "smart" queries
query_gas_limit = 300000
# This is the number of wasm vm instances we keep cached in memory for speed-up
# Warning: this is currently unstable and may lead to crashes, best to keep for 0 unless testing locally
lru_size = 0`

	return customAppTemplate, customAppConfig
}

So what I am going to do is have it return "" as instructed. I guess when importing wasm, all of the above will be needed.

When someone imports wasm, we will need to add all of that. Since we import wasm at Juno.... I'll do it as part of

CosmosContracts/juno#23

and

CosmosContracts/juno#24

Basically what I'm saying is that I'll break, then fix wasm support.

faddat · 2021-06-29T16:40:08Z

@fadeev

So, the template upgrade is finished, but we now need to upgrade Starport. The format that keys are outputted in has changed, resulting in:

{"name":"alice","type":"local","address":"cosmos15dw8wh4h9zgw3jf0qwyjvkux5zm65dgngzfzs3","pubkey":"{\"@type\":\"/cosmos.crypto.secp256k1.PubKey\",\"key\":\"Ao3d7z0zWOu5MgtTFFZbqhid6AuqHjmNDaK67+ZCoz4/\"}","mnemonic":"pull divorce debate height wagon attitude speed decide high essay lawsuit theme stereo learn sausage skull language spice feel jelly sugar salon call message"}
EOF

I believe it's that "type" field, I think it wasn't there before.

faddat · 2021-08-04T02:27:39Z

2 things make this much harder:

spm is separate from the template (I can't find any reason why that is)
go.sum in the template

fadeev · 2021-08-04T03:01:58Z

spm contains things that we abstracted away from the template, because they should always be part of the chain: appd init, appd start, etc. Users shouldn't be messing with commands that are required for the chain to function. It's in a separate repo, because if it was part of Starport, the template would have to import all of Starport, which is huge.

spm is also a very bad name and we should rename it 😁

It also allows us to add features to users' chains without asking them to modify the template. See #1417

faddat · 2021-08-04T03:39:54Z

ahhhhhhhhhh.

OK, good point about the import.

However, I'm now looking at forking spm for various things. I don't think that's how it is intended, but it is how it's working out.

faddat · 2021-08-04T03:41:39Z

spm: starport module right?

faddat · 2021-08-04T03:46:04Z

Back to the topic here-- there is something missing from my work, and I unfortunately do not know what it is.

I thought that the crash was only related to text formatting on the secp keys, but I was wrong.

I scaffolded a chain with the code in the linked PR, and I did the old fashioned

init
add account
gentx
collect gentxs
start

and unfortunately I still got a pretty epic crash.

So I have decided that I am going to try and upgrade dig (https://github.com/faddat/dig) itself, then have a second look at the template. I felt like I was probably missing something pretty easy. I might pull spm into dig (vendor it into the repo) for ease of use while doing this.

fadeev · 2021-08-04T05:44:58Z

Well, if there is something in your fork that is useful for others, we'll consider adding these features to spm proper. Normally, a user shouldn't need to mess with node's cmd.

Pantani · 2021-09-06T13:35:51Z

also, we should update the bandchain-packet to v0.0.2

faddat mentioned this issue Jun 27, 2021

Upgrade to 0.43.0 when starport does CosmosContracts/juno#23

Closed

faddat mentioned this issue Jun 28, 2021

fix: Upgrade the template for 0.43.0-rc0 #1309

Closed

fadeev mentioned this issue Aug 23, 2021

Upgrade the template to Cosmos SDK v0.43 #1491

Closed

fadeev added this to the v0.18 milestone Aug 23, 2021

This was referenced Aug 26, 2021

Update Cosmos SDK to v0.44 tendermint/spn#276

Closed

refactor(templates): update ibc imports #815

Closed

fadeev changed the title ~~Update the template to SDK v0.43~~ Update the template to SDK v0.44 Sep 6, 2021

fadeev assigned ilgooz Sep 6, 2021

ilgooz linked a pull request Sep 15, 2021 that will close this issue

feat: upgrade sdk to v0.44.0 #1575

Merged

1 task

ilgooz closed this as completed in #1575 Sep 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the template to SDK v0.44 #1307

Update the template to SDK v0.44 #1307

fadeev commented Jun 27, 2021 •

edited

Loading

faddat commented Jun 27, 2021

fadeev commented Jun 28, 2021

faddat commented Jun 28, 2021

faddat commented Jun 28, 2021

shravanshetty1 commented Jun 28, 2021

faddat commented Jun 29, 2021 •

edited

Loading

faddat commented Jun 29, 2021

faddat commented Jun 29, 2021

fadeev commented Jun 29, 2021

faddat commented Jun 29, 2021

faddat commented Jun 29, 2021

faddat commented Jun 29, 2021 •

edited

Loading

faddat commented Jun 29, 2021

faddat commented Aug 4, 2021

fadeev commented Aug 4, 2021 •

edited

Loading

faddat commented Aug 4, 2021

faddat commented Aug 4, 2021

faddat commented Aug 4, 2021

fadeev commented Aug 4, 2021

Pantani commented Sep 6, 2021

Update the template to SDK v0.44 #1307

Update the template to SDK v0.44 #1307

Comments

fadeev commented Jun 27, 2021 • edited Loading

faddat commented Jun 27, 2021

fadeev commented Jun 28, 2021

faddat commented Jun 28, 2021

faddat commented Jun 28, 2021

shravanshetty1 commented Jun 28, 2021

faddat commented Jun 29, 2021 • edited Loading

faddat commented Jun 29, 2021

faddat commented Jun 29, 2021

fadeev commented Jun 29, 2021

faddat commented Jun 29, 2021

faddat commented Jun 29, 2021

faddat commented Jun 29, 2021 • edited Loading

faddat commented Jun 29, 2021

faddat commented Aug 4, 2021

fadeev commented Aug 4, 2021 • edited Loading

faddat commented Aug 4, 2021

faddat commented Aug 4, 2021

faddat commented Aug 4, 2021

fadeev commented Aug 4, 2021

Pantani commented Sep 6, 2021

fadeev commented Jun 27, 2021 •

edited

Loading

faddat commented Jun 29, 2021 •

edited

Loading

faddat commented Jun 29, 2021 •

edited

Loading

fadeev commented Aug 4, 2021 •

edited

Loading