Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video slides get keyboard focus (via tab) even when not the active slide or the first slide #304

Closed
theo-staizen opened this issue Sep 12, 2024 · 2 comments
Labels
bug Something isn't working released Implemented and released

Comments

@theo-staizen
Copy link

theo-staizen commented Sep 12, 2024

Describe the bug

Given I have a carousel with a video slide and some images, even if the video is not active, it will still get focus when using tab key

Expected behavior

Video should only be tab accessible when it is the active slide.

How to reproduce

  1. Go to video plugin demo page: https://yet-another-react-lightbox.com/plugins/video
  2. Open the lightbox
  3. Click on next button to move to 2nd or 3rd slide
  4. Press Tab key
  5. Press enter/space. The video will start playing

Screenshots / Logs

No response

Additional context

It's possible for a keyboard user to get "trapped" in the hidden video element and not being able to use left/right arrows to move slides, since the video element has multiple tab stops (pause/play button, volume control, etc) and some of them can intercept left/right arrows.

@igordanchenko
Copy link
Owner

Thank you for reporting this accessibility issue.

@igordanchenko igordanchenko added the bug Something isn't working label Sep 12, 2024
Copy link

🎉 This issue has been resolved in version 3.21.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Implemented and released label Sep 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working released Implemented and released
Projects
None yet
Development

No branches or pull requests

2 participants