Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify & improve configuration #435

Merged
merged 18 commits into from
Feb 9, 2022
Merged

Simplify & improve configuration #435

merged 18 commits into from
Feb 9, 2022

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Feb 8, 2022

Also:

  • Update actions and steps in CI workflows to latest versions of those actions, Python, etc.

How to review

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update release notes.

- Expand class docstring.
- Add typing.
- Don't overwrite values read from file when Config.register() is
  called (fixes #415).
@khaeru khaeru added the enh New features & functionality label Feb 8, 2022
@khaeru khaeru self-assigned this Feb 8, 2022
@khaeru khaeru linked an issue Feb 8, 2022 that may be closed by this pull request
@khaeru khaeru force-pushed the feature/dataclass-config branch from e135031 to 6ec7c4a Compare February 8, 2022 23:09
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #435 (e9e9283) into main (08533cb) will increase coverage by 0.0%.
The diff coverage is 99.3%.

@@          Coverage Diff          @@
##            main    #435   +/-   ##
=====================================
  Coverage   98.5%   98.5%           
=====================================
  Files         41      41           
  Lines       4321    4380   +59     
=====================================
+ Hits        4259    4318   +59     
  Misses        62      62           
Impacted Files Coverage Δ
ixmp/tests/backend/test_base.py 98.9% <ø> (ø)
ixmp/tests/backend/test_jdbc.py 100.0% <ø> (ø)
ixmp/_config.py 96.8% <98.8%> (+1.0%) ⬆️
ixmp/backend/jdbc.py 95.2% <100.0%> (+<0.1%) ⬆️
ixmp/testing/__init__.py 95.8% <100.0%> (-0.1%) ⬇️
ixmp/testing/data.py 97.2% <100.0%> (ø)
ixmp/testing/resource.py 83.0% <100.0%> (ø)
ixmp/tests/test_cli.py 100.0% <100.0%> (ø)
ixmp/tests/test_compat.py 100.0% <100.0%> (ø)
ixmp/tests/test_config.py 100.0% <100.0%> (ø)
... and 2 more

khaeru added a commit that referenced this pull request Feb 8, 2022
@khaeru khaeru linked an issue Feb 8, 2022 that may be closed by this pull request
@khaeru khaeru force-pushed the feature/dataclass-config branch from 74b212d to a483211 Compare February 8, 2022 23:54
khaeru added a commit to iiasa/message_ix that referenced this pull request Feb 8, 2022
khaeru added a commit to iiasa/message_ix that referenced this pull request Feb 8, 2022
@khaeru khaeru linked an issue Feb 9, 2022 that may be closed by this pull request
@khaeru khaeru force-pushed the feature/dataclass-config branch from a474824 to f1b14a3 Compare February 9, 2022 00:39
@khaeru khaeru added this to the 3.5 milestone Feb 9, 2022
@khaeru khaeru force-pushed the feature/dataclass-config branch from f1b14a3 to ad5a55e Compare February 9, 2022 11:00
@khaeru khaeru requested a review from LauWien February 9, 2022 11:21
@khaeru
Copy link
Member Author

khaeru commented Feb 9, 2022

@LauWien the review request is mainly FYI per the workflow and packaging updates, which we could replicate in our other repos. No need to do a deep dive on the code changes; only skim.

@khaeru khaeru merged commit 0c1a143 into main Feb 9, 2022
@khaeru khaeru deleted the feature/dataclass-config branch February 9, 2022 14:53
khaeru added a commit to iiasa/message_ix that referenced this pull request Feb 9, 2022
khaeru added a commit to iiasa/message-ix-models that referenced this pull request Feb 23, 2022
khaeru added a commit to iiasa/message-ix-models that referenced this pull request Feb 23, 2022
khaeru added a commit to iiasa/message-ix-models that referenced this pull request Feb 23, 2022
khaeru added a commit to iiasa/message-ix-models that referenced this pull request Feb 23, 2022
khaeru added a commit to iiasa/message-ix-models that referenced this pull request Mar 31, 2022
khaeru added a commit to iiasa/message-ix-models that referenced this pull request Apr 28, 2022
khaeru added a commit to iiasa/message-ix-models that referenced this pull request May 4, 2022
khaeru added a commit to iiasa/message-ix-models that referenced this pull request May 4, 2022
glatterf42 pushed a commit to iiasa/message-ix-models that referenced this pull request Jan 24, 2023
glatterf42 pushed a commit to iiasa/message-ix-models that referenced this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New features & functionality
Projects
None yet
2 participants