-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify & improve configuration #435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expand class docstring. - Add typing. - Don't overwrite values read from file when Config.register() is called (fixes #415).
5 tasks
khaeru
force-pushed
the
feature/dataclass-config
branch
from
February 8, 2022 23:09
e135031
to
6ec7c4a
Compare
Codecov Report
@@ Coverage Diff @@
## main #435 +/- ##
=====================================
Coverage 98.5% 98.5%
=====================================
Files 41 41
Lines 4321 4380 +59
=====================================
+ Hits 4259 4318 +59
Misses 62 62
|
khaeru
added a commit
that referenced
this pull request
Feb 8, 2022
khaeru
force-pushed
the
feature/dataclass-config
branch
from
February 8, 2022 23:54
74b212d
to
a483211
Compare
khaeru
added a commit
to iiasa/message_ix
that referenced
this pull request
Feb 8, 2022
khaeru
added a commit
to iiasa/message_ix
that referenced
this pull request
Feb 8, 2022
khaeru
force-pushed
the
feature/dataclass-config
branch
from
February 9, 2022 00:39
a474824
to
f1b14a3
Compare
khaeru
force-pushed
the
feature/dataclass-config
branch
from
February 9, 2022 11:00
f1b14a3
to
ad5a55e
Compare
@LauWien the review request is mainly FYI per the workflow and packaging updates, which we could replicate in our other repos. No need to do a deep dive on the code changes; only skim. |
LauWien
approved these changes
Feb 9, 2022
khaeru
added a commit
to iiasa/message_ix
that referenced
this pull request
Feb 9, 2022
khaeru
added a commit
to iiasa/message-ix-models
that referenced
this pull request
Feb 23, 2022
khaeru
added a commit
to iiasa/message-ix-models
that referenced
this pull request
Feb 23, 2022
khaeru
added a commit
to iiasa/message-ix-models
that referenced
this pull request
Feb 23, 2022
khaeru
added a commit
to iiasa/message-ix-models
that referenced
this pull request
Feb 23, 2022
4 tasks
khaeru
added a commit
to iiasa/message-ix-models
that referenced
this pull request
Mar 31, 2022
TODO was addressed in iiasa/ixmp#435
khaeru
added a commit
to iiasa/message-ix-models
that referenced
this pull request
Apr 28, 2022
TODO was addressed in iiasa/ixmp#435
khaeru
added a commit
to iiasa/message-ix-models
that referenced
this pull request
May 4, 2022
TODO was addressed in iiasa/ixmp#435
khaeru
added a commit
to iiasa/message-ix-models
that referenced
this pull request
May 4, 2022
TODO was addressed in iiasa/ixmp#435
glatterf42
pushed a commit
to iiasa/message-ix-models
that referenced
this pull request
Jan 24, 2023
glatterf42
pushed a commit
to iiasa/message-ix-models
that referenced
this pull request
Jan 24, 2023
TODO was addressed in iiasa/ixmp#435
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dataclasses
from the standard library to streamline and simplify theConfig
class.message model dir
does not work #415.Also:
How to review
message model dir
does not work #415 on one's local machine and check that the setting is respected.PR checklist