Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom 404 not found page. Fixes : #4 #20

Closed
wants to merge 3 commits into from

Conversation

MrImmortal09
Copy link

Hello @monarxxjain , This is the recreated PR for the issue Create Custom 404 Page #4 and these are the following chnages I have made in PR.

Changes Made
Designed and created a custom 404 page that seamlessly integrates with the website's theme and design elements.
Modified the routing system to ensure that the custom 404 page is displayed when users navigate to non-existent routes.
Added clear indication on the custom 404 page to inform users that the requested page could not be found.

As per the conversation I have reopened the PR

Screenshot from 2024-03-15 04-46-17

@monarxxjain please review

@monarxxjain
Copy link
Contributor

Great start @MrImmortal09,
It would be better if we remove the footer and make this page Non-scrollable, also you can add a button that will redirect to homepage.
Once done these we can merge you PR

@MrImmortal09
Copy link
Author

Ok @monarxxjain I have got it and I will be back soon with the fixes

@MrImmortal09
Copy link
Author

MrImmortal09 commented Mar 15, 2024

I have added a new component ImagewithButton and used it in the 404 not found page, This will enhance the look as well as serve as a button to Home page. I have also deleted the Footer and also disabled the scrolling.

Screenshot from 2024-03-15 17-47-11

@MrImmortal09
Copy link
Author

@monarxxjain , Please review this PR

@monarxxjain
Copy link
Contributor

@MrImmortal09 Yea now it looks good, but still there are some BUGs in reponsiveness of this page.
Between 786px to 1280px screen appears to be blank. Seems a minor fix to me. Do that and we will be good to go.

@MrImmortal09
Copy link
Author

@monarxxjain I didn't get it, Can you please describe the bug in brief (or else in a short video or anotation on a image).

@monarxxjain
Copy link
Contributor

Here is glimpse of the BUG I am talking about:-
https://github.com/iiitl/Wollete/assets/128830789/de88ceae-ecf6-44b4-8464-785d62feb694

@MrImmortal09
Copy link
Author

MrImmortal09 commented Mar 17, 2024

@monarxxjain I don't know why but it looks good on my side. Please check the attached video and screenshot from a mobile device.
WhatsApp Image 2024-03-17 at 15 44 11

Screencast.from.2024-03-17.15-36-29.webm

@monarxxjain monarxxjain added the accepted-6 6 points label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted-6 6 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants