-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Root Elements #38
Comments
Thanks for writing up the issue, @chadian. I agree that it's important to allow a dynamic tag instead of Because I limited the addon support to Ember 3.16+ (and conjectured that the addon may work for 3.12-3.15), we should be okay with using Potential problemToday, I read the README and RFC #389 to understand the ramifications of allowing a dynamic tag. The RFC has a section called How we teach this. It suggests that a developer should follow the WAI-ARIA specification (e.g. assign the right role) when changing the tag. I'm okay with allowing I think, in this addon's README, we will need to add a warning that changing the tag and passing more things (possibly in the right order) to Action itemsIf you'd like, let's start working on this next week (whenever you are free). As I don't have much experience with accessibility, I think it'd be good to reach out to the Ember A11y team on Discord (at
Please let me know what you think and questions that you may have. Thanks again for your help! |
Reference(s), mainly for myself so that I don't slack
|
Thanks for taking the lead on figuring out the accessibility piece to having dynamic root elements. I don't currently have the time to jump in on implementation for at least 3 more weeks but will be watching this issue and will contribute where I can. I am very much looking forward to seeing this land though so I will circle back. |
@chadian I think I can work on trying out After merging the PR for this issue, we'll probably want to look at how we can bring a solution back to |
I would like to see... πββοΈπββοΈ
Based on our discussion @ijlee2, it might be a useful feature to see the possibility of customizing the root element of the container.
Why and how π¬
How: It looks like this is possible now and is considered stable based on
ember-element-helper
. The compatibility might be limited to Ember 3.11 and up if the modifier needs to be attached to the element.Why: Keeping markup semantic and for cases where the markup element is important (possibly for css selectors)
The text was updated successfully, but these errors were encountered: