Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist for playable media #167

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Playlist for playable media #167

merged 2 commits into from
Aug 7, 2024

Conversation

izderadicka
Copy link
Contributor

Rationale behind this PR:

Many torrents contains several playable files (series, albums ...).
Good players like VLC has posibility to open a playlist - combined with streaming capability of rqbit this enables to play whole content of a torrent in the player (just by open playlist link in the player).

This is a minimal implementation, that works with VLC, couple more things I thought about:

  • MIME type of playlist - the only official MIME is registered by Apple for HLS - this is not exactly this case as as text/plain works with VLC, so I did not explore further - this article is good source for m3u playlist "standard" - https://en.wikipedia.org/wiki/M3U#Internet_media_types
  • ordering of files - now using the ordering provided by the program, not sure if reodering could be useful.
  • UI icon - now on whole torrent - but I though also on possibility to have it on directory level. Current implementation was easiest to implement. But possibility to have playlist for just particular directory sounds interesting.

@ikatson
Copy link
Owner

ikatson commented Aug 7, 2024

Code and feature LGTM, thanks for this!

A couple questions / suggestions (can all be done in a separate PR):

  1. In the UI, looks like you added the icon just next to "delete". There is a dropdown that opens when clicking the cog, maybe move it somewhere there under the dropdown not to clutter the UI with buttons?
  2. Would be cool to use the react modal instead of alert(). There's a few uses of them throughout already (including components), should be easy to add.
  3. In the modal would be cool to display a copyable link, maybe even put it into clipboard
  4. Can you add a screenshot how it looks in the UI pls so that I don't need to compile and check

@ikatson ikatson merged commit e83c3d5 into ikatson:main Aug 7, 2024
4 checks passed
@izderadicka izderadicka changed the title Playlis for playable media Playlist for playable media Aug 7, 2024
@ikatson
Copy link
Owner

ikatson commented Aug 8, 2024

Addresed these here #169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants