UPNP: join all multicast groups from all interfaces (not just the default one picked by the kernel) #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault one picked by the kernel)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out when (at least) in linux you join a multicast group with ifaddr=INADDR_ANY, it binds it to the "interface picked by the system" rather than all.
Looking at the linux kernel implementation, it's the interface which routes to the interface that points to "ip route get 239.255.255.250". However, this isn't ideal, and here's the setup where it broke: the default LAN isn't the default route, but Wireguard VPN is. So "ip route get 239.255.255.250" points to wireguard tunnel which is useless.
This makes it join multicast groups on all interfaces, starting with the default INADDR_ANY (IpV4Addr::UNSPECIFIED in rust).