-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: left and right shifting support #7
Comments
+1 |
2 similar comments
+1 |
+1 |
Yes pwease. Don't forget right and left rotates (or "circular shifts")! |
Actually, it looks like one of the outstanding pull requests has this implemented: #8 But, it's been open since September 2012. 😭 |
+1 |
Hi guys, is there still need in simple shifts? As I found here, it was not merged. So, I need this implementation and have time to commit it. |
I just got here because I could not believe that |
@ilanschnell is there any reason not to merge the PR for this feature? Seems like it's an obvious enhancement... |
I have been thinking about shift operations for a long time, and tried an implementation in a branch. However, as bitarrays are arrays (and not integers) it seems strange why they should support shift operations. The Python list object (as well as Python's array library) does not support shift operations either. |
IMHO, it depends on the intended scope of the library. If it's meant to be a drop-in replacement for Just my two cents :) |
Thanks @wmayner for your input. While it is the list object doesn't support shifts, it also doesn't support |
Can you add support for the << and >> operators? Perhaps look at https://bitbucket.org/quiark/bitarray/src/473cb720d09d/bitarray/_bitarray.c for a reference. Thanks.
The text was updated successfully, but these errors were encountered: