Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to proc-macro-crate 2 #133

Closed
MarijnS95 opened this issue Oct 10, 2023 · 4 comments
Closed

Upgrade to proc-macro-crate 2 #133

MarijnS95 opened this issue Oct 10, 2023 · 4 comments

Comments

@MarijnS95
Copy link

Hey! I'm currently going through a dependency chain to resolve some duplicates of toml and the toml_edit crates, and one of which is solved by proc-macro-crate 2 bumping these dependencies:

bkchr/proc-macro-crate@39a7c18

How easy/trivial (and MSRV-compliant) would it be for num_enum_derive to bump to this crate release? It looks like metadata_checks depends on an older cargo_toml as well which has the toml dependency.

@MarijnS95
Copy link
Author

@illicitonion
Copy link
Owner

Hello! Very reasonable request! As you've noted, this is currently pretty hard for MSRV reasons, and jumping forwards 14 months would be a pretty large jump...

One thing worth mentioning is that proc-macro-crate is an optional dep, and it's only useful at all if you've renamed num_enum in your dep tree (which is very unusual to do). Would just disabling the optional dep help your situation?

@MarijnS95
Copy link
Author

Unfortunately optional deps will show up as part of Cargo.lock and will afaik get picked up by cargo-deny, even if they're not (always) active :/

At least good to know that it doesn't get compiled/used by default.

@illicitonion
Copy link
Owner

This was hopefully fixed in #134 which was released in 0.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants