-
Notifications
You must be signed in to change notification settings - Fork 35
Add prettier config #151
Comments
Will do! |
Okay, so I tried setting it up, you can see it in the <script>
import { createEventDispatcher } from 'svelte';
import classes from '../utils/classes.js';
let _class = null;
export { _class as class };
const dispatch = createEventDispatcher();
</script>
<svelte:options tag="a-popover-button" /><button
type="button"
class={classes('popover-button', _class)}
on:click={e => dispatch('click', { nativeEvent: e })}
{...$$restProps}
>
<slot />
</button>
<style src="./popover-button.scss">
</style> I am mostly bothered by that |
oh, that is a bit annoying. Not an issue I was aware of. Have you been using prettier locally already in your editor with Svelte (just wondering of this is an issue when using config)? If you can't get it working maybe the minimum is to add a comment to disable prettier with the project until the bug for this whitespace removal is resolved. |
Nope, haven't used Prettier before. I'm thinking of opening an issue on the Svelte Prettier config about this and hold on to merging that branch until they fix it |
seems to be an issue already in the plugin repo about putting options at the top: sveltejs/prettier-plugin-svelte#73 When I use prettier, I does move options to the markup part of the code but it doesn't remove whitespace between it and the next element. I suppose that is something in the prettier settings. |
@illright Now that we no longer have |
Would make it easier to do pull requests if the prettier settings were checked into the repo, e.g. .prettierrc or in the package.json
The text was updated successfully, but these errors were encountered: