Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include binaries in npm package #96

Open
bindul opened this issue Apr 19, 2018 · 1 comment
Open

Include binaries in npm package #96

bindul opened this issue Apr 19, 2018 · 1 comment

Comments

@bindul
Copy link

bindul commented Apr 19, 2018

When building in corporate environments, internet access is usually limited. While it may be possible to get access to npm registry through a controlled registry proxy, like nexus; it becomes harder when the package downloaded tries to go out to the internet to download further binaries. It would be great if the binaries could be included in the package, so install does not need intermet access beyond npm registry.

Perhaps related to #71 but different in that this issue requests not requiring a second download at all.

@Nettsentrisk
Copy link

That would also alleviate problems with relying on Github operational status. Right now almost all Github's services are experiencing degraded status, which causes this when trying to install this package:

optipng-bin@6.0.0 postinstall D:\a\1\s\src\WebSite\node_modules\optipng-bin
node lib/install.js

‼ Response code 502 (Gateway Error)
‼ optipng pre-build test failed
i compiling from source

If the binaries were in the package, this would never happen. Relying on Github always being operational is a vulnerability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants