Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to expand define macro and parameter in hover window #43

Open
beyond-fu opened this issue Aug 26, 2023 · 5 comments
Open

Add support to expand define macro and parameter in hover window #43

beyond-fu opened this issue Aug 26, 2023 · 5 comments

Comments

@beyond-fu
Copy link

I think it will be perfect if the define macro and parameters can be expanded in hover window. It is not so intuitive for current hover if having a macro or parameter. Is it possible?

Thanks.

@beyond-fu beyond-fu changed the title Add support to expand define macro and parameters in hover window Add support to expand define macro and parameter in hover window Aug 26, 2023
@kkanhere
Copy link
Collaborator

kkanhere commented Sep 5, 2023

By expand do you mean preprocess it and fill in the tokens? Or do you mean show the definition of the macro? Because latter is what it should be doing right now. The former doesn't seem like a job for language server.

@beyond-fu
Copy link
Author

Yes, I mean preprocess the define macro and parameter and show the value in the hover window. And it's better if the macros and parameters can be processed recursively and displayed correctly. Isn't that what LSP is supposed to do? I don't know about the details of LSP protocol. But Clangd can expand define macro in C/C++. Thanks for your reply!

@beyond-fu
Copy link
Author

I think you can extend the functionality of this plugin beyond the LSP functionality itself.

@kkanhere
Copy link
Collaborator

kkanhere commented Sep 6, 2023

Added it to the todo list but fastest way to get the feature would be to contribute a pull request. Thanks

@beyond-fu
Copy link
Author

Unfortunately, I don't know TypeScript programming and the details of LSP. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants