Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons don't work on mobile (iPhone) #1

Open
jis3r opened this issue Nov 11, 2024 · 3 comments
Open

Icons don't work on mobile (iPhone) #1

jis3r opened this issue Nov 11, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@jis3r
Copy link

jis3r commented Nov 11, 2024

No description provided.

@imfenghuang imfenghuang added the bug Something isn't working label Nov 12, 2024
@imfenghuang
Copy link
Owner

get it. let me fix it.

@imfenghuang
Copy link
Owner

imfenghuang commented Nov 12, 2024

hi @jis3r , the icon div use mouseenter and mouseleave mouse event, however in iOS safari, the mouse event can't be triggered if the element is not a clickable element. So i set role='button' tableindex='0' to the div to make it act as a clickable element.(i tryed only set role='button', it didn't work).

doc: https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariWebContent/HandlingEvents/HandlingEvents.html

@jis3r
Copy link
Author

jis3r commented Nov 12, 2024

Sounds good! I had a similar issue with my icons in the beginning, but interestingly, Svelte handles mouseenter as a klick somehow when on mobile. Maybe there is something similar for Vue? I just tested and SearchIcon for example works on mobile, because the animation gets only triggered initially on mouseenter and then plays. LayersIcon or FrameIcon however don't work as they have a persisting change when hovered (at least thats my guess)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants