Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis, batches, coverage, cdn, umd build and such #7

Closed
1 of 5 tasks
mweststrate opened this issue Dec 30, 2017 · 5 comments · Fixed by #25
Closed
1 of 5 tasks

Add Travis, batches, coverage, cdn, umd build and such #7

mweststrate opened this issue Dec 30, 2017 · 5 comments · Fixed by #25

Comments

@mweststrate
Copy link
Collaborator

mweststrate commented Dec 30, 2017

@Gregjarvez
Copy link
Contributor

I've been researching what batches are but, It ain't kicking it. if you wanna give me a run down I can do that tonight ?. And coverage. test coverage? @mweststrate @benbraou

@benbraou
Copy link
Collaborator

benbraou commented Jan 2, 2018

@Gregjarvez yes it is about test coverage
what is done in https://github.com/mobxjs/mobx may help
For the rest, I let @mweststrate clarify

@mweststrate
Copy link
Collaborator Author

Yep, build, code style, coverage (run jest with --coverage and pipe it through coveralls works pretty great usually), donate badges would be cool. Gitter channel is not needed.

CDN is is simply the unpkg.com link.

Don't bother about the UMD / ESM builds yet, I first want to figure out what the best way is to export the library in the light of supporting different runtime platforms (with and without proxies, see #22)

@mweststrate
Copy link
Collaborator Author

Eh wait, CDN should link to the UMD build, so skip for now :)

@Gregjarvez
Copy link
Contributor

Awesome. I will try and work on them tomorrow !. Thanks for the explanation @mweststrate @benbraou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants