Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

immich is not a compliant byte range server #3097

Closed
1 of 3 tasks
uhthomas opened this issue Jul 3, 2023 · 0 comments · Fixed by #3103
Closed
1 of 3 tasks

immich is not a compliant byte range server #3097

uhthomas opened this issue Jul 3, 2023 · 0 comments · Fixed by #3103

Comments

@uhthomas
Copy link
Member

uhthomas commented Jul 3, 2023

The bug

HTTP ranges have quite a lot of nuance to them. Multiple ranges can be requested at one time for instance.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Range_requests

It would be really nice to use a function like ServeContent from Go, though I can't see an equivalent for nestjs/express? Worst case, we should at least make use of the range function.

private setResRange(res: Res, headers: Record<string, string>, size: number) {

The OS that Immich Server is running on

N/A

Version of Immich Server

v1.65.0

Version of Immich Mobile App

N/A

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

N/A

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant