-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The jpg images saved to Photos on iOS are not the original images from the server. #8815
Comments
Can you be more specific with the filesize? How are you determining this size and what changes are you seeing? I believe the backup symbol is supposed to indicate images that were backed up from that device, which the downloaded one was not, since it was uploaded on Web. |
This happens (#6209) when you upload file with the same filename but different content than you have downloaded to device. |
@mmomjian I exported two images, and renamed them to "upload" and "download" for convenience. I think the change in file size causes the hash of the two images to differ, so duplicate images exist on the server. BTW, I am unable to reproduce this issue with PNG images. When I download the image from the app, the backup button is correctly checked and there is only one image, even if the image was uploaded from the web. So, is anyone else able to reproduce this issue with JPG images, or is it a configuration issue on my end? |
It doesn't appear to be the same issue, as I haven't performed any editing operations on the images. |
Binary comparison of those two would help to track the cause of file size change. It could be many reasons, reverse proxy missconfiguration, unintentional modification some app on your phone, etc. |
Same here. I reported this way back when and this issue is one of the main things i run into as it prevents to download images that are only on the server as it creates duplicates that are re uploaded. |
Same issue here. Discovered it while playing around with what I thought was another issue.
So a note, whatever is causing the alternate-filesize duplicate, is also affecting the share button. Seems to me this should be pretty high priority given it breaks the ability to download images in iOS, in a silent manner of inflated duplicates. So just to be sure, I tried it again:
Like others have tried, I then tried with a PNG and there was no issue. I tried it with an internet meme file that was a jpg and the creation date was changed to today. I guess expected since it is a new different sized file. I'm on the latest release as of this comment. |
Thanks for the report and I agree, I think this impacts usability a bit. As soon as most of your pics and not on device, you can't share / download those pics anymore because it implicitly creates duplicates. |
I have the same issue with jpeg files. You mentioned that PNG files are not affected. I can also add that HEIC (the format in which iPhone camera photos are stored) are not affected either. |
Another suggestion would be to allow immich to save downloaded photos into a dedicated album (on iOS), then we can exclude that album from uploading. It still requires changes in the code, but I imagine that it should be easier than fixing de-duplicated problem (please correct me if I'm wrong). Edit: Maybe also have a look on photo_manager.editor.saveImage() function |
Just chiming in to report I've experienced this as well, although it doesn't seem to impact every single jpg file for me. I have an external library with 863 images in it, all of which I tried to download to my phone, and the automatic sync re-uploaded roughly a third of them. I can also echo that the sizes of the files downloaded to the phone through the app are ever so slightly larger, as seen in the snippet below
|
resolved in #12909, |
The bug
I have noticed that the JPG images downloaded from the server in the iOS app slightly vary in size (they look the same visually), which results in duplicate images on the server
The PNG images are not affected.
The OS that Immich Server is running on
unraid 6.12.6
Version of Immich Server
1.101.0
Version of Immich Mobile App
1.101.0
IOS 17.4.1
Platform with the issue
Your docker-compose.yml content
I don't feel like this is particularity relevant but I can provide if needed
Your .env content
I don't feel like this is particularity relevant but I can provide if needed
Reproduction steps
Relevant log output
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: