feat(server): run microservices in worker thread #9426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying immich with
|
| Latest commit: |
5f2cf91
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6ca1b140.immich.pages.dev |
| Branch Preview URL: | https://feat-worker-threads-microser.immich.pages.dev |
zackpollard
force-pushed
the
feat/worker-threads-microservices
branch
from
7c00a48 to
94d13e4
Compare
zackpollard
force-pushed
the
feat/worker-threads-microservices
branch
from
94d13e4 to
1f84c9a
Compare
bo0tzz
approved these changes
May 14, 2024
| function bootstrap() { | ||
| switch (immichApp) { | ||
| case 'immich': { | ||
| process.title = 'immich_server'; | ||
| if (process.env.INTERNAL_MICROSERVICES === 'true') { |
There was a problem hiding this comment.
Do we eventually want to have an env var for each worker, or rather something like IMMICH_ENABLED_WORKERS=api,web,microservices?
There was a problem hiding this comment.
We can figure this out later, but a pattern like that might make sense
jrasm91
reviewed
May 14, 2024
danieldietzler
approved these changes
May 14, 2024
zackpollard
force-pushed
the
feat/worker-threads-microservices
branch
from
1f84c9a to
13b65e6
Compare
zackpollard
changed the title
…ices for the server
zackpollard
force-pushed
the
feat/worker-threads-microservices
branch
from
13b65e6 to
5f2cf91
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC for bringing microservices into the server instance by using Node.JS worker threads.