Change default values of unusedExports and/or missingExports with import/no-unused-modules

[ehmicky]

Would it make sense to change the default value of unusedExports and/or missingExports? At the moment, they both default to false. Unless I am mistaken, this means that the rule is a noop by default. This confused me at first and I thought the rule was not working. I am wondering if other users might have the same reaction. Would defaulting one of them or both of them to true be a good idea?

(Unrelated note: The no-unused-modules is great, thanks for this! This rule can replace whole libraries dedicated to finding dead code in JavaScript. Being built on top of ESLint, it also benefits from things like IDE integrations. In short, this is great!)

[ljharb]

At this point that’d be a breaking change - but also i don’t think it’d make sense to default only one of them to true - it’d have to default both or neither to the same value.

[ehmicky]

This would need to be delayed until next major version indeed. Both true actually is what makes more sense to me as well.

[klippx]

Would defaulting one of them or both of them to true be a good idea?

Defaulting unusedExports to true is no good for VSCode users, as unusedExports does not work as you'd expect.

• eslint-plugin-import rule import/no-unused-modules does not work with vscode-eslint. microsoft/vscode-eslint#717

[ljharb]

@klippx can you elaborate on what you mean by "this"?

[silverwind]

unusedExports: true works fine in my book. The only case where a exception is needed is for *.config.js files where the exports are not used in any 1st party code and the use in 3rd party code is likely a dynamic import that is not statically analyzable like this one.

[saiichihashimoto]

Is there any reason this isn’t two different rules? They share a setting but otherwise they seem to do two different things.