-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[no-duplicates] prefer-inline should merge type and non-type imports #2675
Comments
There is also a regression in 2.27: Input: import { A } from "./mod";
import { type B } from "./mod"; Output: // 2.26
import { A, type B } from "./mod"; // 2.27
import { A } from "./mod";
import { type B } from "./mod";
|
cc @snewcomer |
@latin-1 I'm also seeing this. Thank you. At one time, I applied all these changes to the ember.js repo and to a large API and everything worked swimmingly. However, I think it was when everything was bundled up in this PR before we split it up. I don't clearly remember. I do plan on looking at this this week. |
I might be mistaken, but I think the docs might be wrong. As I understand it, it is supposed to be |
@simmo that doesn't seem right - the schema is clear that it's a string, not an object. Are you sure you're using the latest version of the plugin? |
ohhh yes, that's correct, they have a different schema (i was checking consistent-type-specifier-style). I don't think it's worth adding a string overload for no-duplicates, nor an object overload for consistent-type-specifier-style, but I agree it ends up being an inconsistency. If the docs are wrong, a PR to fix them would be appreciated! |
My pleasure 😄 - PR for documentation #2684 |
Input:
Output:
The text was updated successfully, but these errors were encountered: