import/no-unresolved should find json files

[jfmengels]

I'm trying to add the plugin to a repo I'm working on, and I'm getting false positives with no-unresolved when importing JSON files.

import setEvent from './fixtures/foo'; // <-- `./fixtures/foo.json` is an existing and valid JSON file

I'm not aware of it being incorrect to import a JSON file, but please let me know if that's the case.

[benmosher]

Weird. Assuming resolve supports it, I think it should. Sounds like a bug.

[shark0der]

Later edit: I had a similar issue and fixed it myself. The culprit was the node_modules scanner: http://stackoverflow.com/a/31656014/539153 (I edited the answer meanwhile).

Somehow, I still don't understand what exactly is going on, but when eslint is invoked with a different cwd (other than project's root), node_modules obviously isn't pointing to what was originally intended and the resolver fails. Fixed it by passing path.resolve(__dirname, 'node_modules'); to fs.readdirSync

[benmosher]

@jfmengels I just added tests but they are passing. Can you take a look? If you can construct a failing test, I can patch it, but I'm not sure what the issue is. Maybe something with your config?

[jfmengels]

Hmm... Yeah, I'll try to take a look at it tonight.

[benmosher]

No rush, speed is up to you. AFAICT it's working. (also, sorry it took so long for me to look at this!)

[jfmengels]

No worries, in fact, I had actually forgotten I had created this issue...

Ok, so the problem is not when you try to do
import foo from "./bar.json"
but when you try to do
import foo from "./bar" (where ./bar is actually ./bar.json).

Adding .json at the end actually solves the problem, but then it showed additionnal errors in default and namespace

I've created test cases in my "fork" of issue-333 here (don't have write rights to add to the branch). I was able to create failing test cases for all three rules. Let me know if you need help with this, and thanks for what you did up till now :)

[benmosher]

Ah, yeah, so for this, import/extensions is the correct solution ATM: https://github.com/benmosher/eslint-plugin-import#importextensions

I think that should resolve it. See note in README about making ['.js'] the default in v2.

[benmosher]

Also, I'm confused why you don't have push rights to a branch, I thought you could push anywhere in the repo?

[jfmengels]

Also, I'm confused why you don't have push rights to a branch, I thought you could push anywhere in the repo?

Fixed it, my bad. Didn't configure my git remote stuff well. Just pushed my issue-333 branch over yours now.

And the import/extensions tip works 👍

[benmosher]

Ah, wild. This is actually an "issue" with node-resolve. By default it only finds .js files.

I just need to add .json to the Node resolver and this should work.

[jfmengels]

😄

[benmosher]

Just published with node resolver v0.2.1