[bugfix] Re: #1332 - skip warning on a type declaration or alias. #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
sharmilajesupaul
force-pushed
the
bugfix-prefer-default-export
branch
from
a686d0e to
382b26c
Compare
|
I came across another the failing case with a single named export i.e. this errors: type foo = string;
export { foo }could we merge those fixes in a separate PR? cc. @ljharb |
|
@sharmilajesupaul if this PR, once rebased, passes tests, then it's up to you if you want to defer those fixes to another PR - but it's also great if you can include them in this PR too :-) |
ljharb
reviewed
Jul 16, 2019
ljharb
approved these changes
Jul 17, 2019
ljharb
force-pushed
the
bugfix-prefer-default-export
branch
3 times, most recently
from
53f79e6 to
3ea8b4a
Compare
|
@sharmilajesupaul i've fixed the test issues around eslint and typescript parser versions; but now there's some seemingly legit failures. Can you look into them? |
sharmilajesupaul
force-pushed
the
bugfix-prefer-default-export
branch
from
3ea8b4a to
adf4aaa
Compare
ljharb
reviewed
Jul 17, 2019
sharmilajesupaul
force-pushed
the
bugfix-prefer-default-export
branch
from
9b48d2e to
22c27b9
Compare
ljharb
requested changes
Jul 17, 2019
ljharb
reviewed
Jul 17, 2019
sharmilajesupaul
force-pushed
the
bugfix-prefer-default-export
branch
2 times, most recently
from
078d712 to
79da3d1
Compare
ljharb
approved these changes
Jul 17, 2019
ljharb
force-pushed
the
bugfix-prefer-default-export
branch
from
79da3d1 to
f4e3f1b
Compare
lencioni
reviewed
Jul 19, 2019
| if (node.exportKind === 'type') return | ||
|
|
||
| if ( | ||
| node.declaration.type === 'TSTypeAliasDeclaration' || | ||
| node.declaration.type === 'TypeAlias' |
There was a problem hiding this comment.
@sharmilajesupaul @brieb should this also ignore interfaces? I believe the Babel/TypeScript AST type is InterfaceDeclaration and the typescript eslint parser type is TSInterfaceDeclaration.
lencioni
added a commit
to lencioni/eslint-plugin-import
that referenced
this pull request
Jul 19, 2019
Similar to import-js#1377, we don't want this rule to apply to exported interfaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1332
Skips warning on a single type declaration or type alias.
Remove the check forI believe this is used in eslint v2 & 3node.exportKindas it isundefinedin all test cases.This should work with
@typescript-eslint/parsertoo, but I'm not testing that here because this repo is still usingtypescript-eslint-parser.cc. @ljharb