Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed documentation for the default values for the order rule (fixes #601) #623

Closed
wants to merge 1 commit into from

Conversation

jfmengels
Copy link
Collaborator

Fixes #601, and replaces #608.

cc @ljharb

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure why tests are failing on master. @benmosher?

@jfmengels
Copy link
Collaborator Author

Hmm, looks like another dependency update breaking... Looking into it a bit.

Anyway, thanks @ljharb for your advice :)

@jfmengels
Copy link
Collaborator Author

Builds on master are broken, and the culprit is Babylon. I fixed the error and have made a PR over there babel/babylon#170.

This is safe to merge, as it's just md files, but we'll need a new Babylon release before being able to have a working test suite. Tip: Do not remove your node_modules folder @benmosher :)

@hzoo
Copy link

hzoo commented Oct 12, 2016

@jfmengels released babylon@6.11.6

@jfmengels
Copy link
Collaborator Author

@hzoo Thanks! Tests are passing now :)

@coveralls
Copy link

coveralls commented Oct 13, 2016

Coverage Status

Changes Unknown when pulling aeb7402 on fix-order-docs into * on master*.

@benmosher
Copy link
Member

rebased and merged via 024a8a7

@benmosher benmosher closed this Nov 2, 2016
@jfmengels jfmengels deleted the fix-order-docs branch November 2, 2016 09:11
@jfmengels
Copy link
Collaborator Author

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants