Aleppo is eating includes

[elbrujohalcon]

Coming from inaka/elvis#467, it looks like aleppo is misunderstanding include attributes.

1> MinContent = "-module(x).\n-include(\"x.hrl\").",
{ok, MinTokens, _} = erl_scan:string(MinContent, {1,1}, [text]),
rp({MinTokens, aleppo:process_tokens(MinTokens)}).
{[{'-',[{text,"-"},{location,{1,1}}]},
  {atom,[{text,"module"},{location,{1,2}}],module},
  {'(',[{text,"("},{location,{1,8}}]},
  {atom,[{text,"x"},{location,{1,9}}],x},
  {')',[{text,")"},{location,{1,10}}]},
  {dot,[{text,".\n"},{location,{1,11}}]},
  {'-',[{text,"-"},{location,{2,1}}]},
  {atom,[{text,"include"},{location,{2,2}}],include},
  {'(',[{text,"("},{location,{2,9}}]},
  {string,[{text,"\"x.hrl\""},{location,{2,10}}],"x.hrl"},
  {')',[{text,")"},{location,{2,17}}]},
  {dot,[{text,"."},{location,{2,18}}]}],
 {ok,[{'-',[{location,{1,1}},{text,"-"},{location,{1,1}}]},
      {atom,[{location,{1,2}},{text,"module"},{location,{1,2}}],
            module},
      {'(',[{location,{1,8}},{text,"("},{location,{1,8}}]},
      {atom,[{location,{1,9}},{text,"x"},{location,{1,9}}],x},
      {')',[{location,{1,10}},{text,")"},{location,{1,10}}]},
      {dot,[{location,{1,11}},{text,".\n"},{location,{1,11}}]},
      {string,[{location,{2,10}},
               {text,"\"x.hrl\""},
               {location,{2,10}}],
              "x.hrl"},
      {eof,0}]}}
ok

As you can see… aleppo is interpreting -include("x.hrl"). as just…

      {string,[{location,{2,10}},
               {text,"\"x.hrl\""},
               {location,{2,10}}],
              "x.hrl"},

…as if it was just "x.hrl", i.e. the string floating around in the module.

[elbrujohalcon]

This works well if we use aleppo:process_tokens(MinTokens, [{include, ["include"]}])., but only if that include folder exists

[elbrujohalcon]

We have the same issue with -include_lib(…)

[elbrujohalcon]

Weirdly, @harenson detected that this works appropriately…

MinContent = "-module(x).-include(\"x.hrl\")."

i.e. without the \n in between, it works.

[elbrujohalcon]

Digging deeper, the wrong behaviour works as this:
If aleppo is parsing a file and it finds an -include or -include_lib attribute for which it can't find the header file, that attribute is incorrectly parsed as a string.
That makes tools dependent on it fail while trying to make sense of the tokens generated by aleppo:process_* functions.

[elbrujohalcon]

Fixed by #55