Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(File): tsx files were not finding correct path to this module #160

Merged
merged 1 commit into from
Oct 29, 2018
Merged

fix(File): tsx files were not finding correct path to this module #160

merged 1 commit into from
Oct 29, 2018

Conversation

jolamar
Copy link
Contributor

@jolamar jolamar commented Oct 26, 2018

screen shot 2018-10-26 at 3 06 06 pm

You would get a compiler error when trying to import rivet-react@0.6.1 into a typescript project


/app/node_modules/rivet-react/build/dist/components/File/File.d.ts
(18,110): Cannot find module '../src/components/util/Rivet'.```

@jolamar jolamar merged commit 82f7956 into develop Oct 29, 2018
@jolamar jolamar deleted the feature/fix-file-component branch October 29, 2018 13:56
@iubot
Copy link
Member

iubot commented Oct 29, 2018

🎉 This PR is included in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burnumd burnumd burnumd approved these changes

@athill athill athill approved these changes

@kennethj kennethj kennethj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jolamar @iubot @kennethj @athill @burnumd