feat: add Rivet 2.x alerts #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcberg
approved these changes
Nov 9, 2022
Comment on lines
13
to
17
| const titleText = 'A Test Component'; | ||
|
|
||
| describe('Dismiss behavior', ()=> { | ||
| it('should include dismiss button', () => { | ||
| const customDismissBehavior = jest.fn(); |
There was a problem hiding this comment.
Is prettier on your branch already? Minor feedback but looks like the indent might be off a little here.
There was a problem hiding this comment.
It was but the files had already been committed. I manually ran prettier on the project.
|
🎉 This PR is included in version 2.0.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
AlertandDismissibleAlertcomponent and associated tests and documentation.