Skip to content
This repository has been archived by the owner on Jun 9, 2021. It is now read-only.

Preallocate file on download #35

Open
indocomsoft opened this issue Sep 8, 2019 · 2 comments
Open

Preallocate file on download #35

indocomsoft opened this issue Sep 8, 2019 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@indocomsoft
Copy link
Owner

indocomsoft commented Sep 8, 2019

Prevent out of space problems (fail preallocation, thus will be retried infinitely by GenRetry), and improve performance.

Especially given large files like webcasts

@indocomsoft indocomsoft added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 8, 2019
@indocomsoft
Copy link
Owner Author

indocomsoft commented Sep 12, 2019

Need https://bugs.erlang.org/browse/ERL-1042 to get fixed before this will succeed on macOS.

Should be fixed when erlang/otp#2386 gets merged

@indocomsoft
Copy link
Owner Author

erlang/otp#2386 is merged and Erlang 22.2 is released, so this will work for macOS (finally) \o/

However, we will need a call to :file.truncate/1 on Linux before Erlang 23.0 containing erlang/otp#2408 is merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant