Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte 4 warning during build #1627

Closed
punyflash opened this issue Jul 28, 2023 · 7 comments · Fixed by #1858
Closed

Svelte 4 warning during build #1627

punyflash opened this issue Jul 28, 2023 · 7 comments · Fixed by #1858
Assignees
Labels
svelte Related to the svelte adapter

Comments

@punyflash
Copy link
Contributor

punyflash commented Jul 28, 2023

Version:

  • @inertiajs/svelte version: 1.0.9
  • svelte version: 4

Describe the problem:

[vite-plugin-svelte] /node_modules/.pnpm/@inertiajs+svelte@1.0.9_svelte@4.1.1/node_modules/@inertiajs/svelte/src/Link.svelte:25:0 A11y: <svelte:element> with click, dblclick, mousedown, mousemove, mouseout, mouseover, mouseup handlers must have an ARIA role
23: </script>
24: 
25: <svelte:element
    ^
26:   this={as}
27:   use:inertia={{

Steps to reproduce:

vite build
@punyflash punyflash added the svelte Related to the svelte adapter label Jul 28, 2023
@reinink
Copy link
Member

reinink commented Jul 30, 2023

Hey can you provide a minimal reproduction of this as a git repo? This makes it much easier for us to reproduce things on our end and ultimately fix it if there is an issue.

Also, for what it's worth our Svelte demo app uses version 4, and I don't see this issue there. You can find that demo app here:

https://github.com/inertiajs/inertia/tree/master/playgrounds/svelte

@punyflash
Copy link
Contributor Author

punyflash commented Jul 30, 2023

Hey can you provide a minimal reproduction of this as a git repo? This makes it much easier for us to reproduce things on our end and ultimately fix it if there is an issue.

Also, for what it's worth our Svelte demo app uses version 4, and I don't see this issue there. You can find that demo app here:

https://github.com/inertiajs/inertia/tree/master/playgrounds/svelte

This issue is quite small, I don't feel a need to create whole repository to show it. It occurred in case when Link.svelte is used. This is just Svelte's A11y warning

You may just use repo that I provided for #1621. https://github.com/punyflash/inertia-test

@jessarcher jessarcher linked a pull request Aug 16, 2023 that will close this issue
@jdion84
Copy link

jdion84 commented Aug 29, 2023

@punyflash did you ever figure this out?

@punyflash
Copy link
Contributor Author

punyflash commented Aug 29, 2023

@punyflash did you ever figure this out?

Fix in #1635. Also, I'd rather not recommend you to use inertia with Svelte 4, as #1621 is even worse

@ingLomeland
Copy link

anyone figured out this problem? I've got a fresh project and not even using the Link component, but I still get this warning

@driesvints
Copy link
Contributor

A PR was sent in but was stalled. It's best that someone picks up the work in a new PR. Thanks

@reinink
Copy link
Member

reinink commented Apr 16, 2024

Decided to fix this using a svelte-ignore (see #1858), and that has been released as part of v1.0.16 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
svelte Related to the svelte adapter
Projects
None yet
6 participants