From e9e252355dcaf3bb42dbb63dffb4ed14e7c14d14 Mon Sep 17 00:00:00 2001 From: Evgeny Kalashnikov Date: Sat, 25 Feb 2023 22:40:59 -0500 Subject: [PATCH] code style improved --- x/Octopus/Concerns/TagSetupModels.php | 1 - x/Octopus/Tag.php | 3 --- x/Octopus/TagThrough.php | 12 +++++------- 3 files changed, 5 insertions(+), 11 deletions(-) diff --git a/x/Octopus/Concerns/TagSetupModels.php b/x/Octopus/Concerns/TagSetupModels.php index be1076d..547ec84 100644 --- a/x/Octopus/Concerns/TagSetupModels.php +++ b/x/Octopus/Concerns/TagSetupModels.php @@ -139,7 +139,6 @@ public function getModelTable() { return $this->modelModel->getTable(); } - /** * Qualify which model we are connecting to as target. * diff --git a/x/Octopus/Tag.php b/x/Octopus/Tag.php index a5c1b23..341f6d8 100644 --- a/x/Octopus/Tag.php +++ b/x/Octopus/Tag.php @@ -7,7 +7,6 @@ use Illuminate\Database\Eloquent\Relations\HasManyThrough; use Illuminate\Database\Eloquent\Relations\HasOneThrough; - class Tag { use Concerns\TagSetupModels; @@ -177,7 +176,6 @@ class Tag */ protected string $targetClass; - /** * Through type id. * @@ -264,7 +262,6 @@ public function __construct( } - /** * Return built relation. * diff --git a/x/Octopus/TagThrough.php b/x/Octopus/TagThrough.php index 96c999d..ebf02e5 100644 --- a/x/Octopus/TagThrough.php +++ b/x/Octopus/TagThrough.php @@ -140,7 +140,6 @@ class TagThrough */ protected string $hasRelation; - /** * Eloquent built in has relation class name. * @@ -185,7 +184,6 @@ class TagThrough */ protected int $categoryThroughType; - /** * Connect key depends on inverse param. * @@ -303,7 +301,6 @@ public function __construct( $this->resetTargetTable(); } - /** * Build tag through relationship. * @@ -436,7 +433,6 @@ protected function buildSelect() { ); } - /** * Build inverse relationship. * @@ -451,7 +447,6 @@ protected function buildTagThroughInverse() { $this->buildSelectInverse(); } - /** * Join to target model inverse. * @@ -506,7 +501,6 @@ protected function whereRelationInverse() { } - /** * Build select statement for the inverse relationship. * @@ -533,6 +527,11 @@ protected function buildSelectInverse() { )); } + /** + * Table alias exists. + * + * @return bool + */ protected function hasTableAlias() { return $this->tableAlias !== null; } @@ -564,7 +563,6 @@ protected function hasTarget() { return $this->target !== null; } - /** * Handle soft deletes if they are enabled in target model. *