Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): reworks --mst to --state=mst #2731

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

frankcalise
Copy link
Contributor

@frankcalise frankcalise commented Aug 8, 2024

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant
  • yarn lint eslint checks pass with new code, if relevant
  • yarn format:check prettier checks pass with new code, if relevant
  • README.md (or relevant documentation) has been updated with your changes

Describe your PR

  • Updates --mst to --state=mst|none with default of mst
  • Refactors remove-mst-markup/code command to read same as remove demo block

@jamonholmgren
Copy link
Member

The more I look at it, the more I like it.

@frankcalise frankcalise marked this pull request as ready for review August 9, 2024 13:18
@frankcalise frankcalise merged commit 3957b0d into feat/expo-router Aug 13, 2024
1 check passed
@frankcalise frankcalise deleted the fix/mst-to-state-opt branch August 13, 2024 12:13
frankcalise added a commit that referenced this pull request Aug 13, 2024
* fix(cli): reworks --mst to --state=mst

* refactor(cli): tidy up MST removal
frankcalise added a commit that referenced this pull request Aug 28, 2024
* feat(cli): experimental expo-router flag

* chore: todo notes for expo router screen gen

* fix(cli): always do expo install --fix check

* fix(cli): prompt about expo-router, fix exp flags output in buildCliCommand

* fix(expo-router): mst directives for template file

* fix(cli): updates for mst markup

* fix(cli): remove-mst src dir param

* fix(cli): update generators for expo-router and obey --mst

* fix(cli): clean up cmd with helpers

* docs: update cli docs for expo router flag

* fix(cli): remove unnecessary file patch for router conversion

* test(cli): add expo router tests

* fix(cli): router prompt grammar, tone down experimental barking

* fix(cli): reworks --mst to --state=mst (#2731 by @frankcalise)

* fix(cli): reworks --mst to --state=mst

* refactor(cli): tidy up MST removal
infinitered-circleci pushed a commit that referenced this pull request Oct 14, 2024
# [10.0.0](v9.10.1...v10.0.0) (2024-10-14)

### Bug Fixes

* **boilerplate:** expo-router initialize i18n ([#2791](#2791) by [@frankcalise](https://github.com/frankcalise)) ([a00113e](a00113e))
* **boilerplate:** Make icon default color explicit, and respond to dark mode ([#2795](#2795) by [@lindboe](https://github.com/lindboe)) ([b82398d](b82398d))
* **cli:** improper MST removal when using CLI prompt, new arch compat ([#2785](#2785) by [@frankcalise](https://github.com/frankcalise)) ([3956652](3956652))
* remove snackify command and references ([#2763](#2763) by [@frankcalise](https://github.com/frankcalise)) ([09671e8](09671e8))

### Features

* Ignite X with Expo 51 ([005ef05](005ef05))
* **boilerplate:** Toggle component refactored to Checkbox, Radio and Switch ([#2667](#2667) by [@frankcalise](https://github.com/frankcalise)) ([54f5208](54f5208))
* **cli:** expo-router option ([#2727](#2727) by [@frankcalise](https://github.com/frankcalise)) ([8bea1f9](8bea1f9)), closes [#2731](#2731)
* **cli:** generator options --dir and --case  ([#2726](#2726) by [@frankcalise](https://github.com/frankcalise)) ([dff3d24](dff3d24))
* **Theming:** Adds theming support with documentation. ([#2636](#2636)) ([a1ae047](a1ae047))
* **v10:** cng default ([#2641](#2641)) ([c7d998d](c7d998d))
* **v10:** Remove MobX-State-Tree flag for non-demo projects ([#2647](#2647) by @Jpoliachik) ([a738243](a738243))
* add MMKV for v10 ([#2660](#2660) by [@frankcalise](https://github.com/frankcalise)) ([9164e5e](9164e5e))

### BREAKING CHANGES

* Ignite X is out now! This update adds:

* Expo Prebuild as default
* Dark mode support
* Static routing with Expo Router
* Flexible generator directory support
* Option to remove mobx-state-tree
* AsyncStorage->MMKV
* New i18n configuration with react-i18next
* Lint configuration updates
* Toggle component → Checkbox, Radio, and Switch
* Improved keyboard avoidance
* Component test example configuration

Read all about it in our blog article!

https://shift.infinite.red/what-is-ignite-x-9ecde0b34d75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants