From 171332c579c52fa120c17990decfe25fdf454d6d Mon Sep 17 00:00:00 2001
From: Trevor Pounds <trevor.pounds@gmail.com>
Date: Thu, 14 Sep 2017 18:21:54 -0400
Subject: [PATCH] Add support for timing sums in statsd input (#3234)

---
 plugins/inputs/statsd/README.md        |  2 ++
 plugins/inputs/statsd/running_stats.go | 11 ++++++++++-
 plugins/inputs/statsd/statsd.go        |  1 +
 plugins/inputs/statsd/statsd_test.go   |  5 +++++
 4 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/plugins/inputs/statsd/README.md b/plugins/inputs/statsd/README.md
index 17f960b2050ae..69d77580dd4b0 100644
--- a/plugins/inputs/statsd/README.md
+++ b/plugins/inputs/statsd/README.md
@@ -143,6 +143,8 @@ metric type:
         for that stat during that interval.
         - `statsd_<name>_stddev`: The stddev is the sample standard deviation
         of all values statsd saw for that stat during that interval.
+        - `statsd_<name>_sum`: The sum is the sample sum of all values statsd saw
+        for that stat during that interval.
         - `statsd_<name>_count`: The count is the number of timings statsd saw
         for that stat during that interval. It is not averaged.
         - `statsd_<name>_percentile_<P>` The `Pth` percentile is a value x such
diff --git a/plugins/inputs/statsd/running_stats.go b/plugins/inputs/statsd/running_stats.go
index fd467dfb662d6..3ce03a87760d7 100644
--- a/plugins/inputs/statsd/running_stats.go
+++ b/plugins/inputs/statsd/running_stats.go
@@ -24,8 +24,10 @@ type RunningStats struct {
 	perc      []float64
 	PercLimit int
 
-	upper float64
+	sum float64
+
 	lower float64
+	upper float64
 
 	// cache if we have sorted the list so that we never re-sort a sorted list,
 	// which can have very bad performance.
@@ -51,6 +53,9 @@ func (rs *RunningStats) AddValue(v float64) {
 	rs.ex += v - rs.k
 	rs.ex2 += (v - rs.k) * (v - rs.k)
 
+	// add to running sum
+	rs.sum += v
+
 	// track upper and lower bounds
 	if v > rs.upper {
 		rs.upper = v
@@ -78,6 +83,10 @@ func (rs *RunningStats) Stddev() float64 {
 	return math.Sqrt(rs.Variance())
 }
 
+func (rs *RunningStats) Sum() float64 {
+	return rs.sum
+}
+
 func (rs *RunningStats) Upper() float64 {
 	return rs.upper
 }
diff --git a/plugins/inputs/statsd/statsd.go b/plugins/inputs/statsd/statsd.go
index 960d88c1d18e2..a905c2092f7e0 100644
--- a/plugins/inputs/statsd/statsd.go
+++ b/plugins/inputs/statsd/statsd.go
@@ -235,6 +235,7 @@ func (s *Statsd) Gather(acc telegraf.Accumulator) error {
 			}
 			fields[prefix+"mean"] = stats.Mean()
 			fields[prefix+"stddev"] = stats.Stddev()
+			fields[prefix+"sum"] = stats.Sum()
 			fields[prefix+"upper"] = stats.Upper()
 			fields[prefix+"lower"] = stats.Lower()
 			fields[prefix+"count"] = stats.Count()
diff --git a/plugins/inputs/statsd/statsd_test.go b/plugins/inputs/statsd/statsd_test.go
index c8164d4f76246..5c6b2065a4d1f 100644
--- a/plugins/inputs/statsd/statsd_test.go
+++ b/plugins/inputs/statsd/statsd_test.go
@@ -407,6 +407,7 @@ func TestParse_Timings(t *testing.T) {
 		"lower":         float64(1),
 		"mean":          float64(3),
 		"stddev":        float64(4),
+		"sum":           float64(15),
 		"upper":         float64(11),
 	}
 
@@ -1154,6 +1155,7 @@ func TestParse_Timings_MultipleFieldsWithTemplate(t *testing.T) {
 		"success_lower":         float64(1),
 		"success_mean":          float64(3),
 		"success_stddev":        float64(4),
+		"success_sum":           float64(15),
 		"success_upper":         float64(11),
 
 		"error_90_percentile": float64(22),
@@ -1161,6 +1163,7 @@ func TestParse_Timings_MultipleFieldsWithTemplate(t *testing.T) {
 		"error_lower":         float64(2),
 		"error_mean":          float64(6),
 		"error_stddev":        float64(8),
+		"error_sum":           float64(30),
 		"error_upper":         float64(22),
 	}
 
@@ -1203,6 +1206,7 @@ func TestParse_Timings_MultipleFieldsWithoutTemplate(t *testing.T) {
 		"lower":         float64(1),
 		"mean":          float64(3),
 		"stddev":        float64(4),
+		"sum":           float64(15),
 		"upper":         float64(11),
 	}
 	expectedError := map[string]interface{}{
@@ -1211,6 +1215,7 @@ func TestParse_Timings_MultipleFieldsWithoutTemplate(t *testing.T) {
 		"lower":         float64(2),
 		"mean":          float64(6),
 		"stddev":        float64(8),
+		"sum":           float64(30),
 		"upper":         float64(22),
 	}