Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output plugin to support Apache IoTDB #11561

Closed
citrusreticulata opened this issue Jul 28, 2022 · 4 comments
Closed

Add output plugin to support Apache IoTDB #11561

citrusreticulata opened this issue Jul 28, 2022 · 4 comments
Assignees
Labels
feature request Requests for new plugin and for new features to existing plugins

Comments

@citrusreticulata
Copy link
Contributor

citrusreticulata commented Jul 28, 2022

Feature Request

Proposal:

I need an output plugin to support Apache IoTDB. And I'd like to be a contributor, all the code has been completed.
What I want to do now is to submit a qualified PR.

Current behavior:

Telegraf does not support Apache IoTDB.

Desired behavior:

Telegraf supports Apache IoTDB as an output target.

Use case:

Apache IoTDB (Database for Internet of Things) is an IoT native database with high performance for data management and analysis, deployable on the edge and the cloud. I'm glad to see that Telegraf will support it.

Apache IoTDB website: https://iotdb.apache.org
Apache IoTDB Github: https://github.com/apache/iotdb

PR submitted

A PR has been submitted. #11557

@citrusreticulata citrusreticulata added the feature request Requests for new plugin and for new features to existing plugins label Jul 28, 2022
@citrusreticulata
Copy link
Contributor Author

I'm glad to see that most of tests passed. But run-readme-linter failed because the CI recognized language option of readme as the first section. Of course, it was short, so the test failed according to its minimum word limit.
This is a really interesting thing. I think a strict check is very good, but I suggest checking first few sections instead.

Then I changed the first section of readme, so the test passed.

Up to now, all tests have passed.

Could you please take the time to review the code?
Thanks!

@citrusreticulata
Copy link
Contributor Author

A test on windows failed. But the error occurred in another plugin:

=== Failed
=== FAIL: plugins/inputs/statsd TestCachesExpireAfterMaxTTL (unknown)
coverage: 78.9% of statements
panic: test timed out after 10m0s

goroutine 15 [running]:
testing.(*M).startAlarm.func1()
	C:/Program Files/Go/src/testing/testing.go:2029 +0xbb
created by time.goFunc
	C:/Program Files/Go/src/time/sleep.go:176 +0x48

goroutine 1 [chan receive, 10 minutes]:
testing.(*T).Run(0xc0003f8820, {0x176023a, 0x1b}, 0x17968b8)
	C:/Program Files/Go/src/testing/testing.go:1487 +0x750
testing.runTests.func1(0x0?)
	C:/Program Files/Go/src/testing/testing.go:1839 +0x9a
testing.tRunner(0xc0003f8820, 0xc0002dfb68)
	C:/Program Files/Go/src/testing/testing.go:1439 +0x214
testing.runTests(0xc0003d0dc0?, {0x1cab7c0, 0x2c, 0x2c}, {0x40?, 0x1ccf212a8a8?, 0x1cb4a60?})
	C:/Program Files/Go/src/testing/testing.go:1837 +0x7e5
testing.(*M).Run(0xc0003d0dc0)
	C:/Program Files/Go/src/testing/testing.go:1719 +0xa72
main.main()
	_testmain.go:199 +0x3aa

goroutine 239 [sync.Cond.Wait, 10 minutes]:
sync.runtime_notifyListWait(0xc00014c290, 0x0)
	C:/Program Files/Go/src/runtime/sema.go:513 +0x146
sync.(*Cond).Wait(0xc00014c280)
	C:/Program Files/Go/src/sync/cond.go:56 +0xa5
github.com/influxdata/telegraf/testutil.(*Accumulator).Wait(0xc000538770, 0x3)
	C:/Users/circleci/project/testutil/accumulator.go:332 +0x1b7
github.com/influxdata/telegraf/plugins/inputs/statsd.TestCachesExpireAfterMaxTTL(0xc000487d40?)
	C:/Users/circleci/project/plugins/inputs/statsd/statsd_test.go:1050 +0x67a
testing.tRunner(0xc000487d40, 0x17968b8)
	C:/Program Files/Go/src/testing/testing.go:1439 +0x214
created by testing.(*T).Run
	C:/Program Files/Go/src/testing/testing.go:1486 +0x725

For more detail please see here.

Maybe this is a random error with a small probability.

@srebhan
Copy link
Member

srebhan commented Aug 16, 2022

@citrusreticulata I think this can be closed now that #11557 is merged!?

@srebhan srebhan self-assigned this Aug 16, 2022
@srebhan srebhan added the waiting for response waiting for response from contributor label Aug 16, 2022
@citrusreticulata
Copy link
Contributor Author

All right! Thanks!

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

No branches or pull requests

2 participants