Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11282 is not backwards compatible even though it says in the notes that it is. #11889

Closed
Darth-Bobo opened this issue Sep 27, 2022 · 0 comments · Fixed by #11896
Closed

#11282 is not backwards compatible even though it says in the notes that it is. #11889

Darth-Bobo opened this issue Sep 27, 2022 · 0 comments · Fixed by #11896
Assignees
Labels
bug unexpected problem or unintended behavior regression something that used to work, but is now broken

Comments

@Darth-Bobo
Copy link

Darth-Bobo commented Sep 27, 2022

Relevant telegraf.conf

N/A

Logs from Telegraf

N/A

System info

telegraf 1.24.x

Docker

No response

Steps to reproduce

  1. Install telegraf 1.23.4
  2. Generate sample config file with filters, e.g.
    telegraf --input-filter agent:global_tags --output-filter agent:global_tags config >old_style.conf
  3. Generate a sample config to reproduce the bug being fixed, e.g.
    telegraf config --input-filter agent:global_tags --output-filter agent:global_tags >old_bug.conf
  4. Install telegraf 1.24.1
  5. Generate sample config files again, e.g.
    telegraf --input-filter agent:global_tags --output-filter agent:global_tags config >new_bug.conf
  6. telegraf config --input-filter agent:global_tags --output-filter agent:global_tags >new_style.conf

Expected behavior

Steps 5 & 6 should produce the same file according to the notes on #11282:

Originally only telegraf --section-filter inputs --input-filter cpu config was supported, where the filter flags were required to > be before the command config. For backwards compatibility this is still supported

Actual behavior

The fix simply flips the bug to the old format of the command line with the output from steps 2+6 being the same and the outputs from 3+5 being the same.

Additional info

No response

@Darth-Bobo Darth-Bobo added the bug unexpected problem or unintended behavior label Sep 27, 2022
@MyaLongmire MyaLongmire added the regression something that used to work, but is now broken label Sep 27, 2022
@sspaink sspaink self-assigned this Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unexpected problem or unintended behavior regression something that used to work, but is now broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants