Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phusion Passenger plugin #256

Closed
v9n opened this issue Oct 12, 2015 · 14 comments
Closed

Phusion Passenger plugin #256

v9n opened this issue Oct 12, 2015 · 14 comments
Labels
feature request Requests for new plugin and for new features to existing plugins

Comments

@v9n
Copy link
Contributor

v9n commented Oct 12, 2015

Hi @sparrc

Not sure if anyone is working on Phusion Passenger. I run PHP at home and Ruby at work so would want to have telegraf support it. Gonna work on it if no one else that you know are working on it.

@sparrc
Copy link
Contributor

sparrc commented Oct 12, 2015

@kureikain Not that I'm aware of, although this looks like a fairly small use-case and I'm not sure it's worth merging into the telegraf repository.

I could be wrong and people in the community can put a +1 here if they want it.

Otherwise, you could keep the plugin in a fork, or write an exec collector that could output the data into JSON and get picked up by telegraf.

@bmxpert1
Copy link
Contributor

+1. Heavy user of passenger myself, so I think I'd make use of this plugin. What sort of metrics are available @kureikain ?

@gotyaoi
Copy link
Contributor

gotyaoi commented Oct 12, 2015

As a note, passenger-status can output to xml with passenger-status --show=xml. Unfortunately it seems there are no plans for a json output: phusion/passenger#1363. On the other hand, it's possible you could run the xml output through a dumb converter program and get json that could be used with the exec plugin. On the gripping hand, perhaps the exec plugin could support other common data formats besides json?

@sparrc
Copy link
Contributor

sparrc commented Oct 12, 2015

My preference would be to have the exec plugin support XML, and then use that to parse the passenger status output

@v9n
Copy link
Contributor Author

v9n commented Oct 13, 2015

Phusion Passenger is very popular in Ruby community though. It's considering the fastest Ruby app server and it can also serve NodeJS and Python.

Right now, exec plugin is quite limited because it doesn't know how to access JSON. It's simply grab the top level field. It also doesn't support tag.

I probably will keep it on my own fork, make it easier to parse and insert metric I think.

@v9n
Copy link
Contributor Author

v9n commented Oct 13, 2015

@bmxpert1 It will included those metric:

  • pool size
  • Processes
  • Requests in top-level queue

Below are tagged by Pid, App root

  • Request in queue
  • Session
  • Mem
  • CPU
  • Processed

Will point your to my fork in a few day.

@bmxpert1
Copy link
Contributor

@kureikain thank you!

@benweissmann
Copy link

Any update on this? I'd also love to use a Passenger plugin.

@sparrc
Copy link
Contributor

sparrc commented Jan 7, 2016

@kureikain did you have a plugin for this in your fork?

If so, if you could rebase it off the 0.3.0 branch and send up a PR it would be much appreciated!

@v9n
Copy link
Contributor Author

v9n commented Jan 14, 2016

@sparrc Yes, will send up a PR for this plugin. I have it in my fork. Will do when I'm home

@neckhair
Copy link

A huge 👍 from me!

@v9n
Copy link
Contributor Author

v9n commented Jan 15, 2016

PR is open #522. Will add unit test and document

@v9n
Copy link
Contributor Author

v9n commented Jan 15, 2016

@danielnelson danielnelson added feature request Requests for new plugin and for new features to existing plugins and removed plugin request labels Aug 12, 2017
@russorat
Copy link
Contributor

code merged. resolving issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

No branches or pull requests

8 participants