Address already in use with webhooks input during reload

[danielnelson]

Bug report

If you send Telegraf a SIGHUP when using the webhooks input, an error is emitted. Most likely the webhook server is not restarted.

Relevant telegraf.conf:

[[inputs.webhooks]]
  service_address = ":1619"
  [inputs.webhooks.github]
    path = "/github"

System info:

Telegraf v1.5.0~pre3006ccbf (git: master 3006ccb)

Steps to reproduce:

1. Start Telegraf with webhooks input
2. pkill -HUP telegraf

Expected behavior:

Webhooks server restarted

Actual behavior:

2017-08-18T01:45:44Z E! Error in plugin [inputs.webhooks]: E! Error starting server: listen tcp :1619: bind: address already in use

[dsalbert]

Hi @danielnelson,

I've redesigned this plugin, based on zipkin http listener. The key part is to avoid printing error message in situation where http.ErrServerClosed occur. Please take a look -
#3206

Output after sending 2 HUP signals:

2017-09-07T13:24:58Z I! Starting Telegraf v1.5.0~preebfd822
2017-09-07T13:24:58Z I! Loaded outputs: file
2017-09-07T13:24:58Z I! Loaded inputs: inputs.webhooks
2017-09-07T13:24:58Z I! Tags enabled: host=dankan-ThinkPad-T440s
2017-09-07T13:24:58Z I! Agent Config: Interval:5s, Quiet:false, Hostname:"dankan-ThinkPad-T440s", Flush Interval:10s
2017-09-07T13:24:58Z I! Started the webhooks_github on /github
2017-09-07T13:24:58Z I! Started the webhooks service on :1619
2017-09-07T13:25:03Z I! Reloading Telegraf config
2017-09-07T13:25:03Z I! Hang on, flushing any cached metrics before shutdown
2017-09-07T13:25:03Z I! Stopping the Webhooks service
2017-09-07T13:25:03Z I! Starting Telegraf v1.5.0~preebfd822
2017-09-07T13:25:03Z I! Loaded outputs: file
2017-09-07T13:25:03Z I! Loaded inputs: inputs.webhooks
2017-09-07T13:25:03Z I! Tags enabled: host=dankan-ThinkPad-T440s
2017-09-07T13:25:03Z I! Agent Config: Interval:5s, Quiet:false, Hostname:"dankan-ThinkPad-T440s", Flush Interval:10s
2017-09-07T13:25:03Z I! Started the webhooks_github on /github
2017-09-07T13:25:03Z I! Started the webhooks service on :1619
2017-09-07T13:25:09Z I! Reloading Telegraf config
2017-09-07T13:25:09Z I! Hang on, flushing any cached metrics before shutdown
2017-09-07T13:25:09Z I! Stopping the Webhooks service
2017-09-07T13:25:09Z I! Starting Telegraf v1.5.0~preebfd822
2017-09-07T13:25:09Z I! Loaded outputs: file
2017-09-07T13:25:09Z I! Loaded inputs: inputs.webhooks
2017-09-07T13:25:09Z I! Tags enabled: host=dankan-ThinkPad-T440s
2017-09-07T13:25:09Z I! Agent Config: Interval:5s, Quiet:false, Hostname:"dankan-ThinkPad-T440s", Flush Interval:10s
2017-09-07T13:25:09Z I! Started the webhooks_github on /github
2017-09-07T13:25:09Z I! Started the webhooks service on :1619

Thanks,
Daniel

[dsalbert]

Solved by #3206