Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudwatch Input: min/max/average/sum etc selective statistics #5609

Closed
CpuID opened this issue Mar 20, 2019 · 6 comments · Fixed by #5544
Closed

Cloudwatch Input: min/max/average/sum etc selective statistics #5609

CpuID opened this issue Mar 20, 2019 · 6 comments · Fixed by #5544
Assignees
Labels
area/aws AWS plugins including cloudwatch, ecs, kinesis feature request Requests for new plugin and for new features to existing plugins
Milestone

Comments

@CpuID
Copy link

CpuID commented Mar 20, 2019

Feature Request

It would be beneficial (for AWS costs) to be able to select specific "statistics" only for the given metrics/dimensions, so when pulling a high volume of metrics from Cloudwatch you can keep costs under control.

Proposal:

Eg. you may only care about average and max, but not min or sum. This would halve the % of retrievals involved.

https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_GetMetricData.html seems to provide the ability to specify, there also seems to be some on https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_GetMetricStatistics.html

Current behavior:

Retrieves all "statistics" for a given metric / dimension, which is somewhere around 6~ each.

Desired behavior:

Selectively pull the ones you want.

Use case: [Why is this important (helps with prioritizing requests)]

End user cost, plus this will have a rate limit benefit also (efficiency).

@CpuID
Copy link
Author

CpuID commented Mar 20, 2019

@CpuID
Copy link
Author

CpuID commented Mar 20, 2019

Related: #5420 (same goal of optimizing traffic to Cloudwatch, different approach). Both probably complement eachother tbh.

@danielnelson danielnelson added feature request Requests for new plugin and for new features to existing plugins area/aws AWS plugins including cloudwatch, ecs, kinesis labels Mar 20, 2019
@danielnelson danielnelson added this to the 1.11.0 milestone Mar 20, 2019
@danielnelson
Copy link
Contributor

I think this should be fairly easy to do, we should try to add this in while doing the #5420 improvement.

@CpuID
Copy link
Author

CpuID commented Mar 20, 2019

@glinton ping for visibility, as per @danielnelson 's suggestion. Feel free to get the core functionality of #5420 working first, if you think you can sneak this into your improvements it would be awesome :)

lmk if you become time constrained for any reason, and I can see if I can find time to collaborate and get it over the line

@CpuID
Copy link
Author

CpuID commented Mar 20, 2019

I'm inclined to say, if @glinton has time constraints and can't get it in, get #5420 out of the way first to avoid having to refactor this feature request twice.

@glinton
Copy link
Contributor

glinton commented Mar 22, 2019

I've started on implementing this, hoping to have a testable build for you by EOD Monday. Glad it was brought up when it was though, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/aws AWS plugins including cloudwatch, ecs, kinesis feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants