Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template id is integer and should be a long or string #28

Closed
moisoiu opened this issue Dec 21, 2023 · 2 comments
Closed

Template id is integer and should be a long or string #28

moisoiu opened this issue Dec 21, 2023 · 2 comments

Comments

@moisoiu
Copy link

moisoiu commented Dec 21, 2023

Hello,

Description:

  • Template Id that are generated on the InfoBip platform for Templates have very long id (ex: 200000000035654)

Version: 2.1.2
Environment : Production
Reproducing : Any Id that is generated by InfoBip platform that is longer than the int

Suggest a Fix:

Can we change in the SendEmailApi.cs from

int? templateid = default(int?)

to

string? templateid = default(string?)

or

long? templateid = default(long?)

The issue seems to be fixed on Java https://github.com/infobip/infobip-api-java-client/blob/master/src/main/java/com/infobip/api/EmailApi.java

But the issue is not fixed on other libraries (Ex: php -> https://github.com/infobip/infobip-api-php-client/blob/master/Infobip/Api/EmailApi.php)

@moisoiu
Copy link
Author

moisoiu commented Dec 21, 2023

The issue was also reported here: infobip/infobip-api-java-client#37

@lvukadinovic-ib
Copy link
Contributor

lvukadinovic-ib commented Dec 28, 2023

Hi @moisoiu,
thank you for using our library and for reporting the issue. We've released a new version (2.1.3) which fixes the mentioned problem. I'm marking this as closed. Feel free to reopen the issue if it still persists.

Kind regards,
Luka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants