Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Makefile and version info #52

Closed
p-offtermatt opened this issue Sep 12, 2023 · 0 comments · Fixed by #54
Closed

Add a Makefile and version info #52

p-offtermatt opened this issue Sep 12, 2023 · 0 comments · Fixed by #54
Assignees
@p-offtermatt
Labels
prio:shouldhave For high priority issues that we *should* have because they are major outcomes

Comments

@p-offtermatt
Copy link
Member

CometMock should feature a Makefile that provides common functionality, like installing, to make it more opaque and streamlined to users.

Related, CometMock should also provide a version command that can be run to check the current version. Naming should likely come from the CometBFT version that it mocks, e.g. v0.37.x
@p-offtermatt p-offtermatt self-assigned this Sep 12, 2023
@p-offtermatt p-offtermatt added the prio:shouldhave For high priority issues that we *should* have because they are major outcomes label Sep 12, 2023
@p-offtermatt p-offtermatt linked a pull request Sep 12, 2023 that will close this issue
Adds a Makefile and version command #54
Merged
@p-offtermatt p-offtermatt mentioned this issue Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p-offtermatt p-offtermatt

Labels
prio:shouldhave For high priority issues that we *should* have because they are major outcomes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds a Makefile and version command informalsystems/CometMock
1 participant
@p-offtermatt