Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Link-Time Optimization (LTO) #3

Closed
zamazan4ik opened this issue Oct 16, 2024 · 1 comment
Closed

Enable Link-Time Optimization (LTO) #3

zamazan4ik opened this issue Oct 16, 2024 · 1 comment
Labels

Comments

@zamazan4ik
Copy link

Description

Hi!

I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit.

I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where additionally to regular release optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO should also help to reduce the build-time overhead with LTO. If we enable it on the Cargo profile level, users, who install the application with cargo install, will get the LTO-optimized version "automatically". E.g., check cargo-outdated Release profile. If for some distros LTO creates problems (I've seen multiple issues with LTO in AUR e.g.) - maintainers can opt-out of LTO in their specific cases.

Basically, it can be enabled with the following lines:

[profile.release]
lto = true

I have made quick tests (Apple M1, macOS): enabling lto = true reduced the binary size from 2.2 Mib to 1.8 Mib. The project also builds fine with LTO on my Linux setup (Fedora).

Thank you.

Related work

N/A

@yorickpeterse
Copy link
Contributor

Since this applies to more or less all our projects, I'll close this in favour of this issue so the discussion is kept in a single place 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants