Implement blob size limit #7
Open
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rather than manually checking for the blob size, which might change in the future, I think we should instead catch the exception, and re-send the post without the embed then. What do you think? |
|
You're probably right, but I have no idea how to do this in a clean way. |
|
Unfortunately, the problem cannot be detected when the blob is uploaded via cardyb.bsky.app (the upload is successful). The error appears only when you try to publish the post. |
|
Alright, let's go with that implementation for now then. Could you add a test? |
|
I've been trying to write the test for the past two days, but without success. As I said before, I'm not very experienced. I'm sorry. |
|
It's okay! Thanks for trying. I'll write them when I have some time 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a blob size limit (one million bytes) (see also bluesky-social/atproto#1740). If you try to send a larger blob, an error message is returned:
This PR implements a check of the size of the file being sent and if it exceeds the limit, the blob is not sent and the embed does not have a thumbnail.