Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate ruff #142

Closed
szymonmaszke opened this issue Feb 24, 2023 · 1 comment · Fixed by #144
Closed

Integrate ruff #142

szymonmaszke opened this issue Feb 24, 2023 · 1 comment · Fixed by #144
Assignees
@szymonmaszke
Labels
high High Priority normal Normal Difficulty

Comments

@szymonmaszke
Copy link
Contributor

Check whether scraping flake and flakeheaven for ruff would not be the best idea to proceed.

Difficulty will emerge when choosing rules as most of that has to be hand verified.
@szymonmaszke szymonmaszke added high High Priority hard Hard Difficulty labels Feb 24, 2023
@szymonmaszke szymonmaszke self-assigned this Feb 24, 2023
@szymonmaszke szymonmaszke added normal Normal Difficulty and removed hard Hard Difficulty labels Feb 24, 2023
@szymonmaszke
Copy link
Contributor Author

szymonmaszke commented Feb 24, 2023 •
edited
Loading

Most of the current checks are implemented (and there are some additional ones which seem to fit well), namely:

  • pyupgrade (UP)
  • flake8-2020 (YTT)
  • flake8-bandit (S)
  • flake8-blind-except (BLE)
  • flake8-boolean-trap (FBT)
  • flake8-comprehensions (C4)
  • flake8-datetimez (DTZ)
  • flake8-debugger (T10)
  • flake8-import-conventions (ICN)
  • flake8-no-pep420 (INP)
  • flake8-print (T20)
  • flake8-raise (RSE)
  • flake8-return (RET)
  • flake8-self (SLF)
  • flake8-type-checking (TCH)
  • flake8-unused-arguments (ARG)
  • eradicate (ERA)

Currently missing for ruff which we would like to support:

  • flake8-noqa (open issue here)
  • flake8-annotations-coverage (open issue here)
  • flake8-annotations-complexity (open issue here)

flake8-cognitive-complexity is better supported via settings (see here)

@szymonmaszke szymonmaszke mentioned this issue Feb 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szymonmaszke szymonmaszke

Labels
high High Priority normal Normal Difficulty
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: integrate ruff inovintell/py-template
1 participant
@szymonmaszke