Add CSV Format search/replace to Search & Replace Tab #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 18, 2017 22:36
Created CSV entry in Search & Replace tab Pass csv data to replace_values function Note: Change counter will only increment on cells changed and not number of changes made in a cell Missing: Multilingual support
CSV label now uses esc_html_e function. Updated default to no longer include "(optional)" for improved readability. Still lacking translation to other langauges.
Per the important GUID note here: https://codex.wordpress.org/Changing_The_Site_URL#Important_GUID_Note
|
@devbanana Do you have thoughts on this pull request? I'd like to fix issues if they exist. |
bueltge
reviewed
Jun 15, 2017
There was a problem hiding this comment.
@devbanana THe codex of the source is wrong. I added two hints an two examples, maybe you will fix this and add this to the pull request? Thanks a lot for your effort.
| @@ -327,13 +337,17 @@ public function backup_table( $search = '', $replace = '', $table, $new_table_pr | |||
| //skip replace if no search pattern | |||
| //check if we need to replace something | |||
| //skip primary_key | |||
| if ( $search !== '' && $column !== $primary_key ) { | |||
| if ( $search !== '' && $column !== $primary_key && $column !== "guid") { | |||
There was a problem hiding this comment.
Always we use single quote mark, is much faster.
|
|
||
| $edited_data = $this->replace->recursive_unserialize_replace( | ||
| $search, $replace, | ||
| $value | ||
| ); | ||
|
|
||
| if($csv != null) { |
There was a problem hiding this comment.
We need whitespace, like in this example if ( $csv !== null ) { and also a identical usage, strict !== instead of ==.
|
I merge this pull request in a new branch to fix the formatting issues. |
bueltge
added a commit
that referenced
this pull request
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found myself in need of a bulk search/replace function for some time now to handle broken links that occur when importing a site from HTML to Wordpress. To that end, I've added a CSV option to the Search & Replace tab.
The CSV option's label is missing translations for German and Chinese.