feat!: move to swift based framework for didcomm, jose and peer did #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goncalo-frade-iohk
requested review from
elribonazo,
hamada147,
curtis-h,
amagyar-iohk and
cristianIOHK
elribonazo
reviewed
Feb 16, 2024
| @@ -404,7 +404,7 @@ | |||
| CODE_SIGN_STYLE = Automatic; | |||
| CURRENT_PROJECT_VERSION = 1; | |||
| DEVELOPMENT_ASSET_PATHS = "\"DIDChat/Preview Content\""; | |||
| DEVELOPMENT_TEAM = 89TW38X994; | |||
| DEVELOPMENT_TEAM = ""; | |||
elribonazo
approved these changes
Feb 16, 2024
Comment on lines
141
to
148
| // logger.debug(message: "Getting ecnumbasis", metadata: [ | ||
| // .maskedMetadataByLevel(key: "DID", value: did.string, level: .debug) | ||
| // ]) | ||
| // return try CreatePeerDIDOperation( | ||
| // autenticationPublicKey: publicKey, | ||
| // agreementPublicKey: publicKey, | ||
| // services: [] | ||
| // ).computeEcnumbasis(did: did, publicKey: publicKey) |
There was a problem hiding this comment.
Do we need to keep this commented code?
| ) | ||
| } | ||
|
|
||
| private func authenticationFromPublicKey(publicKey: PublicKey) throws -> VerificationMaterialAuthentication { | ||
| // |
hamada147
reviewed
Feb 16, 2024
Comment on lines
40
to
41
| print(error) | ||
| print() |
There was a problem hiding this comment.
Remove Print from code.
Suggested change
| print(error) | |
| print() |
There was a problem hiding this comment.
One of them I will leave since it is in the demo ;)
hamada147
approved these changes
Feb 16, 2024
goncalo-frade-iohk
force-pushed
the
feature/update-dependencies
branch
3 times, most recently
from
213184c to
7cbf5b9
Compare
BREAKING CHANGE: Updated Pluto and Message public interface This changes are required to provide the following. - the old didcomm library didnt allow for extra headers that was essencial to prism mediator - this peer did library is updated with last specifications specs required by the agent and prism mediator - this jose library provides a full implementation of the jose capabilities we require The amount of changes is big because the peer did changes required a few changes on how we process keys and resolve secrets Besides that since the previous libraries were not build in swift, we are actually getting rid of 37MB of framework size
goncalo-frade-iohk
force-pushed
the
feature/update-dependencies
branch
from
7cbf5b9 to
8f968e2
Compare
goncalo-frade-iohk
added a commit
that referenced
this pull request
Feb 27, 2024
…120) BREAKING CHANGE: There is an update to the public API that is used directly with DIDComm
atala-dev
added a commit
that referenced
this pull request
Feb 27, 2024
# [5.0.0](4.0.1...5.0.0) (2024-02-27) ### Bug Fixes * schema download optional ([#116](#116)) ([37655c1](37655c1)) * feat!: move to swift based framework for didcomm, jose and peer did (#120) ([558164f](558164f)), closes [#120](#120) ### BREAKING CHANGES * There is an update to the public API that is used directly with DIDComm
atala-dev
added a commit
that referenced
this pull request
Mar 25, 2024
# [5.0.0](4.0.1...5.0.0) (2024-03-25) ### Bug Fixes * schema download optional ([#116](#116)) ([37655c1](37655c1)) * update apollo that has an important fix for app publishing ([#128](#128)) ([5e9eee9](5e9eee9)) * feat!: move to swift based framework for didcomm, jose and peer did (#120) ([558164f](558164f)), closes [#120](#120) ### BREAKING CHANGES * There is an update to the public API that is used directly with DIDComm
goncalo-frade-iohk
added a commit
that referenced
this pull request
May 14, 2024
…120) BREAKING CHANGE: There is an update to the public API that is used directly with DIDComm Signed-off-by: goncalo-frade-iohk <goncalo.frade@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Updated Pluto and Message public interface
This changes are required to provide the following.
The amount of changes is big because the peer did changes required a few changes on how we process keys and resolve secrets
Besides that since the previous libraries were not build in swift, we are actually getting rid of 37MB of framework size
Checklist
My PR contains...
My changes...
Documentation
Tests