Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement conway governance committee create-hot-key-authorization-certificate command #145

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Aug 5, 2023

Changelog

- description: |
    Implement `conway governance committee create-hot-key-authorization-certificate` command
# uncomment types applicable to the change:
  type:
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - documentation  # change in code docs, haddocks...

Context

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy force-pushed the newhoggy/implement-conway_governance_committee_create-hot-key-authorization-certificate branch from 1a57fc3 to b96750a Compare August 5, 2023 11:54
@newhoggy newhoggy marked this pull request as ready for review August 5, 2023 12:04
@newhoggy newhoggy force-pushed the newhoggy/implement-conway_governance_committee_create-hot-key-authorization-certificate branch 2 times, most recently from c0413c7 to 30dd929 Compare August 5, 2023 12:43
@@ -621,6 +625,19 @@ Usage: cardano-cli conway governance committee key-gen-hot --verification-key-fi

Create a cold key pair for a Constitutional Committee Member

Usage: cardano-cli conway governance committee create-hot-key-authorization-certificate
( --cc-cold-key STRING
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@newhoggy newhoggy force-pushed the newhoggy/implement-conway_governance_committee_create-hot-key-authorization-certificate branch from 30dd929 to fb38604 Compare August 7, 2023 13:12
@newhoggy newhoggy requested a review from Jimbo4350 August 7, 2023 14:44
@newhoggy newhoggy force-pushed the newhoggy/implement-conway_governance_committee_create-hot-key-authorization-certificate branch from fb38604 to 165cad3 Compare August 18, 2023 07:32
@newhoggy newhoggy dismissed Jimbo4350’s stale review August 18, 2023 07:37

Comments addressed

@newhoggy newhoggy enabled auto-merge August 18, 2023 07:37
@newhoggy newhoggy added this pull request to the merge queue Aug 18, 2023
Merged via the queue into main with commit 3ef1fa9 Aug 18, 2023
@newhoggy newhoggy deleted the newhoggy/implement-conway_governance_committee_create-hot-key-authorization-certificate branch August 18, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants