Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement conway governance committee create-cold-key-resignation certificate #146

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Implement conway governance committee create-cold-key-resignation certificate #146

merged 1 commit into from
Aug 18, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Aug 5, 2023 •
edited
Loading

Changelog

- description: |
   Implement `conway governance committee create-cold-key-resignation` certificate
# uncomment types applicable to the change:
  type:
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - documentation  # change in code docs, haddocks...

Context

Implements #4

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review August 5, 2023 12:38
Jimbo4350
Jimbo4350 previously requested changes Aug 7, 2023
View reviewed changes
...es/golden/help/experimental_governance_committee_create-cold-key-resignation-certificate.cli Outdated

Available options:
--cc-cold-key STRING Constitutional Committee cold key (hex-encoded).
--cc-cold-key-file FILE Filepath of the Consitutional Committee cold key.
Copy link
Contributor

@Jimbo4350 Jimbo4350 Aug 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should stick to the current cli format: --cold-verification-key-file. The cc is redundant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@Jimbo4350 Jimbo4350 mentioned this pull request Aug 7, 2023
Merged
10 tasks
@newhoggy newhoggy force-pushed the origin/newhoggy/implement-conway_governance_committee_create-cold-key-resignation-certificate branch from 14efe50 to eb55387 Compare August 7, 2023 13:20
@newhoggy newhoggy requested a review from Jimbo4350 August 7, 2023 13:21
@newhoggy newhoggy force-pushed the origin/newhoggy/implement-conway_governance_committee_create-cold-key-resignation-certificate branch from eb55387 to c76787e Compare August 7, 2023 13:30
@CarlosLopezDeLara CarlosLopezDeLara mentioned this pull request Aug 8, 2023
Closed
27 tasks
@newhoggy newhoggy force-pushed the origin/newhoggy/implement-conway_governance_committee_create-cold-key-resignation-certificate branch from c76787e to 7a3e5d4 Compare August 18, 2023 07:19
@newhoggy newhoggy dismissed Jimbo4350’s stale review August 18, 2023 07:19

Comments addressed

carbolymer
carbolymer reviewed Aug 18, 2023
View reviewed changes
cardano-cli/src/Cardano/CLI/EraBased/Legacy.hs Outdated
parseLegacyCommands

-- * CLI command and flag types
, module Cardano.CLI.Commands.Legacy
Copy link
Contributor

@carbolymer carbolymer Aug 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between this and erabased legacy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a stray commit that found its way into the PR. I don't see it anymore.

carbolymer
carbolymer reviewed Aug 18, 2023
View reviewed changes
cardano-cli/src/Cardano/CLI/EraBased/Legacy.hs Outdated
Copy link
Contributor

@carbolymer carbolymer Aug 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all parsers, shouldn't they go into EraBased.Options module?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Let me make a new PR for this.

@newhoggy newhoggy force-pushed the origin/newhoggy/implement-conway_governance_committee_create-cold-key-resignation-certificate branch from 7a3e5d4 to b4ebd91 Compare August 18, 2023 09:33
@newhoggy newhoggy added this pull request to the merge queue Aug 18, 2023
@newhoggy newhoggy removed this pull request from the merge queue due to a manual request Aug 18, 2023
@newhoggy newhoggy force-pushed the origin/newhoggy/implement-conway_governance_committee_create-cold-key-resignation-certificate branch from b4ebd91 to 26dc796 Compare August 18, 2023 10:10
@newhoggy newhoggy enabled auto-merge August 18, 2023 10:10
@newhoggy newhoggy added this pull request to the merge queue Aug 18, 2023
@newhoggy newhoggy removed this pull request from the merge queue due to a manual request Aug 18, 2023
@newhoggy newhoggy force-pushed the origin/newhoggy/implement-conway_governance_committee_create-cold-key-resignation-certificate branch from 26dc796 to af0717f Compare August 18, 2023 10:45
@newhoggy newhoggy enabled auto-merge August 18, 2023 10:48
@newhoggy newhoggy added this pull request to the merge queue Aug 18, 2023
Merged via the queue into main with commit 138a93b Aug 18, 2023
@newhoggy newhoggy deleted the origin/newhoggy/implement-conway_governance_committee_create-cold-key-resignation-certificate branch August 18, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newhoggy @carbolymer @Jimbo4350