-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --verification-key
option to committee key-hash
command
#187
Add --verification-key
option to committee key-hash
command
#187
Conversation
c8099b5
to
3e12ca6
Compare
@@ -794,7 +794,10 @@ Usage: cardano-cli conway governance committee key-gen-hot --verification-key-fi | |||
|
|||
Create a cold key pair for a Constitutional Committee Member | |||
|
|||
Usage: cardano-cli conway governance committee key-hash --verification-key-file FILE | |||
Usage: cardano-cli conway governance committee key-hash | |||
( --verification-key STRING |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds this command line option ⬆️
--verification-key-file FILE | ||
Input filepath of the verification key. | ||
Input filepath of the Constitutional Committee Member | ||
key (hot or cold). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More descriptive help.
let asTypes = | ||
[ FromSomeType (AsVerificationKey AsCommitteeHotKey ) ACommitteeHotKey | ||
, FromSomeType (AsVerificationKey AsCommitteeColdKey) ACommitteeColdKey | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are still reasonably strict about what keys are accepted.
|
||
-- | The source from which a verification key of an unspecified key role can be | ||
-- derivied. | ||
data AnyVerificationKeySource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the naming convention that XyzSource
is a thing from which an Xyz
can be derived.
In this case, the Xyz
is VerificationKey
. The Any
prefix means any keyrole
.
cardano-cli/src/Cardano/CLI/Types/Key/AnyVerificationKeyText.hs
Outdated
Show resolved
Hide resolved
… it returns input file only
3e12ca6
to
aed9e56
Compare
aed9e56
to
ac35314
Compare
Changelog
Context
Checklist
See Running tests for more details
.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7