-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Governance drep
and vote
command groups
#191
Conversation
aa136e4
to
dbc39f0
Compare
@@ -0,0 +1,31 @@ | |||
Usage: cardano-cli allegra governance drep delegation-certificate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was told this is wrong, so I'm not sure if governance drep
should appear everywhere: https://input-output-rnd.slack.com/archives/G011N23CEAE/p1691759918638949?thread_ts=1691691053.122579&cid=G011N23CEAE
cc: @CarlosLopezDeLara
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm following the "Cardano-CLI Feature Requirements to support Voltaire" document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely Dreps only exist in Conway. Not in previous eras.
AnyEraDeciderConwayOnwards cOn -> | ||
GovernanceDRepRegistrationCertificateCmd . ConwayOnwardRegTarget cOn | ||
<$> asum [ RegisterStakePool cOn | ||
<$> pStakePoolRegistrationParserRequirements envCli' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not just a DRep command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will revisit this after finding more about this requirement.
pStakeTarget cOnwards = | ||
asum | ||
[ TargetStakePool cOnwards <$> pStakePoolVerificationKeyOrHashOrFile | ||
, TargetVotingDrep cOnwards <$> pDRepVerificationKeyOrHashOrFile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, it's not just a DRep command
… and getStakeAddressFromVerifier to Cardano.CLI.Read so it can be re-used
dbc39f0
to
7cfbd6b
Compare
Changelog
Context
This changes the
conway governance
command structure to look like this:Some types and functions in affected
conway governance
modules were moved out of those modules to facilitate code sharing of those types between those modules.See the
cli
files for details.Checklist
See Running tests for more details
.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7